Please, prevent macros from messing up textdomain

[iceiceice]

Dugi: Another possibility is that it works fine in game but it's broken when you save and reload the game. It's a bit harder for me to imagine how that could happen in the code but it's easier to see how it wouldn't have been spotted.

[Dugi]

It's not caused by reloading, because the dialogue is in the start scenario event that you will not see after reloading. It was spotted there by a translator, I just dug the problem from the save file when I was investigating it.

[Iris]

I was told that somebody (maybe zookeeper, I wasn't told this exactly in that PM) is looking at it already, but I have no more information how is that going. I will ask him when I'll be on IRC (I am currently quite submerged in some physics research).

I don’t really think anybody was looking into this, and the implementation details of WML aren’t zookeeper’s domain. I am on the case now, though, with bug #22962 [Gna.org] filed and including a proper isolated test case for everyone’s convenience.

[Dugi]

Thank you.

[Iris]

And fixed (in master and 1.12).

Expect to see the fix in version 1.12.1, assuming I didn’t fail to account for some weird corner case — some testing in the meantime would be highly appreciated.

[Dugi]

Good job. Thanks.

[kiss]

default_language_1.12.png (84.18 KiB) Viewed 3832 times

To be sure, does this also fix that?

[Iris]

No, that’s a separate issue that gfgtdf fixed not long after 1.11.19 was released (bug #22928 [Gna.org]).