Healthy units heal 2 even on turns they attack?

Having trouble with the game? Report issues and get help here. Read this first!

Moderators: Forum Moderators, Developers

Forum rules
Before reporting issues in this section, you must read the following topic:
scwizard
Posts: 10
Joined: September 15th, 2014, 6:49 pm

Healthy units heal 2 even on turns they attack?

Post by scwizard » September 22nd, 2014, 3:26 pm

When I move and attack with a healthy dwarf I still heal 2 hp at the beginning of the next turn.

To reproduce just play the first level of The Hammer of Thursagan and attack something with a healthy dwarf. Save is attached.

This is 1.10.7
Attachments
Bug.gz
(20.46 KiB) Downloaded 74 times

User avatar
iceiceice
Developer
Posts: 1056
Joined: August 23rd, 2013, 2:10 am

Re: Healthy units heal 2 even on turns they attack?

Post by iceiceice » September 22nd, 2014, 3:56 pm

I could be wrong but I don't think it's a bug. Healthy units basically get "healthy healing" of +2 no matter what, in addition to the rest healing of +2 on turns they didn't move or attack. If poisoned they only take -6 hp because of the healthy healing.

I looked at the help page just now for the healthy trait, it's a bit vague about what is supposed to happen but I don't think it contradicts this... Did you read somewhere something that contradicts what you are seeing?

User avatar
Crow_T
Posts: 851
Joined: February 24th, 2011, 4:20 am

Re: Healthy units heal 2 even on turns they attack?

Post by Crow_T » September 22nd, 2014, 4:32 pm

http://www.wesnoth.org/manual/stable/ma ... tml#traits
Healthy
Renowned for their vitality, some dwarves are sturdier than others and can rest heal even when traveling or fighting. Healthy units have 1 HP plus 1 HP per level more than usual and rest heal the usual 2 HP after each turn regardless.
The phrasing of the above seems ambiguous :hmm:

User avatar
tekelili
Posts: 1038
Joined: August 19th, 2009, 9:28 pm

Re: Healthy units heal 2 even on turns they attack?

Post by tekelili » September 22nd, 2014, 5:04 pm

Healthy effect description looks clear for me, I always understood this effect as its current behavior :|
Be aware English is not my first language and I could have explained bad myself using wrong or just invented words.
World Conquest II

scwizard
Posts: 10
Joined: September 15th, 2014, 6:49 pm

Re: Healthy units heal 2 even on turns they attack?

Post by scwizard » September 23rd, 2014, 3:03 am

Crow_T wrote:http://www.wesnoth.org/manual/stable/ma ... tml#traits
Healthy
Renowned for their vitality, some dwarves are sturdier than others and can rest heal even when traveling or fighting. Healthy units have 1 HP plus 1 HP per level more than usual and rest heal the usual 2 HP after each turn regardless.
The phrasing of the above seems ambiguous :hmm:
The description in the in game documentation is completely different from what you quoted.
Healthy uints have 1 HP plus 1 HP per level more than usual and rest heal the usual 2 HP after each turn they did not fight. They also suffer a quarter less damage from poison.
Here's a screenshot: http://i.imgur.com/r3K5WK2.png

Here's my suggestion for a description:

"Healthy units heal every turn as if they had rested, even on turns when they did not rest."

User avatar
tekelili
Posts: 1038
Joined: August 19th, 2009, 9:28 pm

Re: Healthy units heal 2 even on turns they attack?

Post by tekelili » September 23rd, 2014, 3:10 am

scwizard wrote:The description in the in game documentation is completely different from what you quoted.
You are right, that description looks wrong. I was referring to description you get from tooltip when mouseover trait :oops:
Be aware English is not my first language and I could have explained bad myself using wrong or just invented words.
World Conquest II

User avatar
SkyOne
Posts: 1310
Joined: January 3rd, 2009, 7:23 pm

Re: Healthy units heal 2 even on turns they attack?

Post by SkyOne » September 23rd, 2014, 3:11 am

scwizard wrote:Here's a screenshot: http://i.imgur.com/r3K5WK2.png
Ah-ha, :) I have also recognized it on your way.
It has been written for a long time. This is on the help menu from BfW 1.4.7:
"Renowned for their vitality, some dwarves are sturdier than others and can rest even when travelling." + _"

Healthy units have 2 more HP than usual and rest heal 2 additional HP after each turn they did not fight."
So maybe, editing it on the help.cfg will be necessary?
Fate of a Princess/feedback thread: "What is in own heart that is the most important, not who you are."
Drake Campaign: Brave Wings/feedback thread, Naga Campaign: Return of the Monster, Saurian Campaign: Across the Ocean
Northern Forces - now on 1.12 server

scwizard
Posts: 10
Joined: September 15th, 2014, 6:49 pm

Re: Healthy units heal 2 even on turns they attack?

Post by scwizard » September 23rd, 2014, 3:12 am

iceiceice wrote:Healthy units basically get "healthy healing" of +2 no matter what, in addition to the rest healing of +2
This is false in 1.10.7. Healthy units that don't move or attack are healed for +2, the same as if they had moved or attacked.

Max
Posts: 1449
Joined: April 13th, 2008, 12:41 am

Re: Healthy units heal 2 even on turns they attack?

Post by Max » September 23rd, 2014, 6:47 am

the in-game description was confusing me too, i've made a bug report some years ago:
http://gna.org/bugs/?13283

User avatar
iceiceice
Developer
Posts: 1056
Joined: August 23rd, 2013, 2:10 am

Re: Healthy units heal 2 even on turns they attack?

Post by iceiceice » September 23rd, 2014, 2:21 pm

I'm wrong, and it looks like this was changed at some point.

It was changed in these commits:
https://github.com/wesnoth/wesnoth/commit/0f03c1f8
https://github.com/wesnoth/wesnoth/commit/71688998

The commit message is "make healthy units always rest heal", it seems pretty accurate. However, I don't like the current tooltip, it seems unfortunately confusing.

http://imgur.com/rcyHVt8

Does that mean they always rest heal an amount 1 hp + 1 hp per level? So healthy steelclad would heal 3? (Edit: I know it doesn't do that, the question is just to illustrate the confusion.) This should be fixed.

Also, I think the committer in the two commits above just neglected to update the help page.

User avatar
ChaosRider
Posts: 846
Joined: April 15th, 2012, 1:15 pm

Re: Healthy units heal 2 even on turns they attack?

Post by ChaosRider » September 23rd, 2014, 2:41 pm

Maybe change that trait name for lesser regeneration.
Creator of WOTG (+2880 units), MWC (+615 units), SurvivorsArea, RandomColosseum, RC WOTG, RC MWC, ColosseumRandomClonesBattle, BetweenDarknessAndLight, StealingWeapons, MoreUnitsForms, MoreDamageTypes, CanBeOnlyOne, ColosseumOneWinner, BonusSpam, CriticalStrike - available at 1.12 Wesnoth server.

User avatar
tekelili
Posts: 1038
Joined: August 19th, 2009, 9:28 pm

Re: Healthy units heal 2 even on turns they attack?

Post by tekelili » September 23rd, 2014, 3:17 pm

I find tooltip clear, it may only be confusing if you don´t understand game concept "rest", wich by the way is stackable with healing so should never be called "regeneration", wich is not stackable with healing.

If players dont understand there is a concept called "rest", then thats problem should be addressed, imo.
Be aware English is not my first language and I could have explained bad myself using wrong or just invented words.
World Conquest II

User avatar
iceiceice
Developer
Posts: 1056
Joined: August 23rd, 2013, 2:10 am

Re: Healthy units heal 2 even on turns they attack?

Post by iceiceice » September 23rd, 2014, 3:20 pm

Tekelili: The only thing I'm saying is, there should be a line break between "Always rest heals" and "+1 HP and +1 HP per level"

User avatar
tekelili
Posts: 1038
Joined: August 19th, 2009, 9:28 pm

Re: Healthy units heal 2 even on turns they attack?

Post by tekelili » September 23rd, 2014, 3:44 pm

iceiceice wrote:Tekelili: The only thing I'm saying is, there should be a line break between "Always rest heals" and "+1 HP and +1 HP per level"
That is a good idea, I myself used a end of line when coding traits descriptions to separate "pure effects" from "descriptions".

But I know what I am talking about when pointing players dont understand concept "rest". In my addon there is a training benefict called "Always rest heals" and I have found even developers that didnt have concept clear :eng:
Be aware English is not my first language and I could have explained bad myself using wrong or just invented words.
World Conquest II

User avatar
iceiceice
Developer
Posts: 1056
Joined: August 23rd, 2013, 2:10 am

Re: Healthy units heal 2 even on turns they attack?

Post by iceiceice » September 23rd, 2014, 3:52 pm

Hmm, ok. :hmm:

We have a whole page in the help dedicated to healing, it seems pretty complete and accurate:
http://i.imgur.com/6nHBwon.png

What exactly are people confused about?

Post Reply