[1.14.1] Sceptre of Fire - 9 - Caverns of Flame - Repeated messages and possible defeat upon killing final elf

[Kal]

I don't see any mention of this in the changelogs for the newer releases so I figure I'm good to give a report from a slightly older version.

Upon killing the final elf in my playthrough, Rugnur says his line, the cave fills with lava things die etc etc, but when Thursagan dies he gives his normal death line, and after the pass that fills the hex the final elf unit was killed on with lava, it shows that elf dying again and Rugnur says his line again then the elf dies again and Rugnur says his line again, this repeats about ten times. Then I get a bunch of error messages in the top left, several more passes of lava/units dying, then I get the Defeat message and I have to reload or whatever.
If instead Thursagan is on a hex that doesn't get turned to lava until later, then I still get the elf dying/Rugnur talking a bunch of times plus error messages, but the scenario finishes correctly. I had no issues completing the scenario by surviving until the volcano erupts on its own.

Additionally, on the turn that the elves have a line about noticing the volcano is erupting and to escape, I saw some elves get killed as if by lava but their hexes didn't turn to lava. I couldn't get a save file to reproduce that particular issue, but maybe it's related. (Edit - I watched the replay and saw no evidence of elves dying at start of turn at all, so maybe ignore this bit.)

Reproduction:
Load the attached save file, leave Thursagan where he is and kill the Elvish Avenger for the Defeat variant, or move Thursagan adjacent to the Avenger (or any other hex that doesn't become lava until later, most likely) then kill the Avenger. I assume this would happen with Rugnur as well, but he's already moved and is on a 'safe' hex.

Window 7 SP1, Wesnoth 1.14.1, English [GB].
Build information:

Code: Select all

The Battle for Wesnoth version 1.14.1
Running on Microsoft Windows 7 Service Pack 1 (6.1.7601)

Game paths
==========

Data dir:        D:\Games\Battle for Wesnoth 1.14.1
User config dir: C:\Users\USER\Documents\My Games\Wesnoth1.14
User data dir:   C:\Users\USER\Documents\My Games\Wesnoth1.14
Saves dir:       C:\Users\USER\Documents\My Games\Wesnoth1.14\saves
Add-ons dir:     C:\Users\USER\Documents\My Games\Wesnoth1.14\data\add-ons
Cache dir:       C:\Users\USER\Documents\My Games\Wesnoth1.14\cache

Libraries
=========

Boost:             1.59
OpenSSL/libcrypto: 1.1.0f (runtime 1.1.0f)
Cairo:             1.10.2 (runtime 1.10.2)
Pango:             1.30.1 (runtime 1.30.1)
SDL:               2.0.4  (runtime 2.0.4)
SDL_image:         2.0.0  (runtime 2.0.0)
SDL_mixer:         2.0.0  (runtime 2.0.0)
SDL_ttf:           2.0.12 (runtime 2.0.12)

Features
========

Experimental OpenMP support:    yes
JPG screenshots:                no
Lua console completion:         yes
Legacy bidirectional rendering: no
Win32 notifications back-end:   yes

Log:

Code: Select all

20180723 14:01:58 error wml: tried to fire 'die' or 'last breath' event on unit from the unit's 'die' or 'last breath' event with first_time_only=no!
Invalid WML found: WML array length changed during [foreach] iteration
Invalid WML found: WML array length changed during [foreach] iteration
Invalid WML found: WML array length changed during [foreach] iteration
Invalid WML found: WML array length changed during [foreach] iteration
Invalid WML found: WML array length changed during [foreach] iteration
Invalid WML found: WML array length changed during [foreach] iteration
Invalid WML found: WML array length changed during [foreach] iteration
Invalid WML found: WML array length changed during [foreach] iteration
Invalid WML found: WML array length changed during [foreach] iteration

[zookeeper]

Easy to miss, but it's there:

Code: Select all

## Version 1.14.2
 ### Campaigns
   [...]
   * Sceptre of Fire:
     * In 'Caverns of Flame', fixed various issues with the volcano eruption.

Now, I can't be absolutely positive that I caught all possible problems with that sequence (since it is pretty complicated), but I haven't seen any reports of problems since then.