Feedback Thread for Xara's Add-ons

Review and rate user-made single and multiplayer campaigns and scenarios.

Moderators: Forum Moderators, Developers

Re: Feedback Thread for Xara's Add-ons

Postby Ravana » September 17th, 2017, 4:07 pm

That can be fixed with replace all on prefixes for EoMa and EoM. Also there is removed succubus unit, and 2 renamed EoM elementals.

I have done it as
Code: Select all
ravana@ravana-think ~/.local/share/wesnoth/1.12/data/add-ons/SXCollection $ history | grep "AE_"
  574  grep -rl AE_myh_windsong_ . | xargs sed -i "s/AE_myh_windsong_/AE_myh_/g"
  580  grep -rl AE_myh_wargs_ . | xargs sed -i "s/AE_myh_wargs_/AE_myh_/g"
  581  grep -rl AE_myh_therians_ . | xargs sed -i "s/AE_myh_therians_/AE_myh_/g"
  582  grep -rl AE_myh_vampires_ . | xargs sed -i "s/AE_myh_vampires_/AE_myh_/g"
  583  grep -rl AE_myh_celestials_ . | xargs sed -i "s/AE_myh_celestials_/AE_myh_/g"
  584  grep -rl AE_myh_devilings_ . | xargs sed -i "s/AE_myh_devilings_/AE_myh_/g"
  585  grep -rl AE_myh_Succubus . | xargs sed -i "s/AE_myh_Succubus/AE_myh_Blood_Apprentice/g"
  591  grep -rl AE_myh_Fire_Sprite2 . | xargs sed -i "s/AE_myh_Fire_Sprite2/AE_myh_Flame_Sprite/g"
  592  grep -rl AE_myh_Fire_Sprite3 . | xargs sed -i "s/AE_myh_Fire_Sprite3/AE_myh_Flame_Spirit/g"
  595  history | grep "AE_"
User avatar
Ravana
Moderator
 
Posts: 1447
Joined: January 29th, 2012, 12:49 am
Location: Estonia

Re: Feedback Thread for Xara's Add-ons

Postby Araja » September 20th, 2017, 3:37 pm

What is this code block? I've never seen anything like it in WML before.
User avatar
Araja
 
Posts: 718
Joined: May 28th, 2009, 9:56 am
Location: Bath, England

Re: Feedback Thread for Xara's Add-ons

Postby Ravana » September 20th, 2017, 3:44 pm

Those are unix shell commands. Your text editor might also support replacing all in all opened files.

Those lines read as "s/AE_myh_windsong_/AE_myh_/g" -> "switch/this/with this/everywhere"
User avatar
Ravana
Moderator
 
Posts: 1447
Joined: January 29th, 2012, 12:49 am
Location: Estonia

Re: Feedback Thread for Xara's Add-ons

Postby Araja » September 20th, 2017, 4:32 pm

Ah, I see.

I've noticed something now which I feel dumb for not noticing earlier, but the code block references Era of Myths units, which I don't believe this add-on uses. As well as the default units, it mainly uses Era of Magic and Era of Four Moons, with invalid ID errors so far only occurring for EoMa units as far as I've tested.

Looking into the scenario files, the final battles also make use of a few more eras and factions, and I'm not readily sure how many of those have experienced ID changes. It seems this is a larger task than I first thought.

Was it only Era of Magic and Era of Myths whose ID formats are different? That would certainly simplify matters.
User avatar
Araja
 
Posts: 718
Joined: May 28th, 2009, 9:56 am
Location: Bath, England

Re: Feedback Thread for Xara's Add-ons

Postby Ravana » September 20th, 2017, 4:37 pm

Should be only those two. Though Archaic might have some changes, and is likely to continue changing.
User avatar
Ravana
Moderator
 
Posts: 1447
Joined: January 29th, 2012, 12:49 am
Location: Estonia

Re: Feedback Thread for Xara's Add-ons

Postby Araja » September 20th, 2017, 4:41 pm

That's good information to know, since it hopefully restricts the need to employ find-and-replace to a single folder, that being the Era of Magic scenarios. I don't think Myths or Archaic make an appearance.
User avatar
Araja
 
Posts: 718
Joined: May 28th, 2009, 9:56 am
Location: Bath, England

Re: Feedback Thread for Xara's Add-ons

Postby Araja » September 20th, 2017, 7:25 pm

After spending alot of time making fixes, I found some scenarios also have spawned units from factions outside of the main enemies for that scenario, which catch you out if you only ran find-and-replace for those factions. Some units have had their names more heavily modified in Ageless, such as the Abyss Mage now being the Void Mage and Ifreeti now being called Ifreet. I don't think the "Plantium Warrior" ever existed to begin with, however :P

I've come to the conclusion there are too many test-and-fix cycles required to resolve all the error conditions, at least without excessive time and effort. Unfortunately this may have had its' day now the creator has moved on.
User avatar
Araja
 
Posts: 718
Joined: May 28th, 2009, 9:56 am
Location: Bath, England

Re: Feedback Thread for Xara's Add-ons

Postby Ravana » September 20th, 2017, 8:24 pm

Almost all of that testing is done on command line, I provide list of generic scenario-compatible units with each release of ageless.

That addon contains 470 different AE unit types.

find_missing.sh
Code: Select all
for i in $(cat $1); do
    if grep -q $i unit_list.txt; then :; else echo $i; fi
done


Those not found in my list of https://github.com/ProditorMagnus/Oroci ... t_list.cfg
Code: Select all
ravana@ravana-think ~/Downloads $ ./find_missing.sh used.txt
AE_chs_chaos_empire_Arbalestier
AE_chs_chaos_empire_Assault_Drone
AE_chs_chaos_empire_Bowman
AE_chs_chaos_empire_Crossbowman
AE_chs_chaos_empire_Drone
AE_chs_chaos_empire_Heavy_Longbowman
AE_chs_chaos_empire_Longbowman
AE_chs_chaos_empire_Protector_Drone
AE_chs_chaos_empire_Rayblade
AE_chs_chaos_empire_Runner_Drone
AE_chs_chaos_empire_Sentry_Drone
AE_efm_dalefolk_shifter
AE_efm_dalefolk_Wilderman
AE_efm_seastates_Elite_Cataphract
AE_efm_seastates_Elite_MerchantLord
AE_LizardEye
AE_mag_Al_Kamija_Air_Elemental
AE_mag_Al_Kamija_Air_God
AE_mag_Al_Kamija_Camel_Rider
AE_mag_Al_Kamija_Carpet_Master
AE_mag_Al_Kamija_Carpet_Rider
AE_mag_Al_Kamija_Dimensional_Gate
AE_mag_Al_Kamija_Earth_Avatar
AE_mag_Al_Kamija_Earth_Elemental
AE_mag_Al_Kamija_Efreeti
AE_mag_Al_Kamija_Fire_Avatar
AE_mag_Al_Kamija_Fire_Elemental
AE_mag_Al_Kamija_Fire_God
AE_mag_Al_Kamija_Great_Jinn
AE_mag_Al_Kamija_Heavy_Camel_Rider
AE_mag_Al_Kamija_Heavy_Summoner
AE_mag_Al_Kamija_Jinn
AE_mag_Al_Kamija_Neutral_Summoner
AE_mag_Al_Kamija_Novice_Summoner
AE_mag_Al_Kamija_Rhami
AE_mag_Al_Kamija_RhamiDatu
AE_mag_Al_Kamija_RhamiKai
AE_mag_Al_Kamija_Summoner
AE_mag_Al_Kamija_Summons_Master
AE_mag_Al_Kamija_Water_Avatar
AE_mag_Al_Kamija_Water_Elemental
AE_mag_Al_Kamija_Water_God
AE_mag_Al_Kamija_Wonderful_Jinn
AE_mag_Barbarians_Ancient_Cyclops
AE_mag_Barbarians_Barbarian
AE_mag_Barbarians_Barbarian_Berserker
AE_mag_Barbarians_Barbarian_King
AE_mag_Barbarians_Barbarian_Lord
AE_mag_Barbarians_Cyclops
AE_mag_Barbarians_Cyclops_Breaker
AE_mag_Barbarians_Cyclops_Destroyer
AE_mag_Barbarians_Fire_Cyclops
AE_mag_Barbarians_Goblin_Archer
AE_mag_Barbarians_Goblin_Assassin
AE_mag_Barbarians_Goblin_Kamikaze
AE_mag_Barbarians_Goblin_Rouser
AE_mag_Barbarians_Goblin_Runt
AE_mag_Barbarians_Goblin_Sniper
AE_mag_Barbarians_Goblin_Warbanner
AE_mag_Barbarians_Mighty_Cyclops
AE_mag_Barbarians_Orcish_Warbanner
AE_mag_Barbarians_Orcish_Warrior
AE_mag_Barbarians_Raging_Cyclops
AE_mag_Barbarians_Roc_Rider
AE_mag_Barbarians_Troll_Fire_Wizard
AE_mag_Barbarians_Troll_Sorcerer
AE_mag_Barbarians_Troll_Warbanner
AE_mag_Darkblood_Battle_Toad
AE_mag_Darkblood_Chaos_Rider
AE_mag_Darkblood_Mystic
AE_mag_Darkblood_Ranged_Toad
AE_mag_Darkblood_Salamander
AE_mag_Darkblood_Saurian_Pikeman
AE_mag_Darkblood_Shaman_Adept
AE_mag_Darkblood_Shamanistic_Toad
AE_mag_Darkblood_Shooter
AE_mag_Darkblood_Swamp_Mage
AE_mag_Darkblood_Toad
AE_mag_Darkblood_Wyvern
AE_mag_Darkblood_Wyvern_Rider
AE_mag_Darkblood_Wyvern_Tamer
AE_mag_Destroyers_Apocalypse
AE_mag_Destroyers_Atokpi
AE_mag_Destroyers_Atokpi_General
AE_mag_Destroyers_Atokpi_Samurai
AE_mag_Destroyers_Beast
AE_mag_Destroyers_Bone_Golem
AE_mag_Destroyers_Cyclops_Skeleton
AE_mag_Destroyers_Extinct_Cyclops_Mage
AE_mag_Destroyers_Legendary_Cyclops
AE_mag_Destroyers_Mara
AE_mag_Destroyers_Moloch
AE_mag_Destroyers_Nightmare
AE_mag_Destroyers_Omen
AE_mag_Destroyers_Pirafly
AE_mag_Destroyers_Pirania_Monstruosa
AE_mag_Destroyers_Punisher
AE_mag_Kharos_Adept_of_Light
AE_mag_Kharos_Brown_Warrior
AE_mag_Kharos_Cavalry_Archer
AE_mag_Kharos_Cleric
AE_mag_Kharos_Elemental_Archer
AE_mag_Kharos_Fanatic
AE_mag_Kharos_Golden_Warrior
AE_mag_Kharos_Heavy_Cavalry_Archer
AE_mag_Kharos_Kirios
AE_mag_Kharos_Plantium_Warrior
AE_mag_Kharos_Prophet_of_Light
AE_mag_Kharos_Protector
AE_mag_Kharos_Revenger
AE_mag_Kharos_Shielder
AE_mag_Kharos_Silver_Warrior
AE_mag_Kharos_Sister_of_Light
AE_mag_Kharos_Slicer
AE_mag_Kharos_Sun_Follower
AE_mag_Kharos_Sun_Guardian
AE_mag_Kharos_War_Banner
AE_mag_Kharos_White_Warrior
AE_mag_Runemasters_Balloon
AE_mag_Runemasters_Dwarvish_Heavy_Warrior
AE_mag_Runemasters_Dwarvish_Rune_Warrior
AE_mag_Runemasters_Dwarvish_Tank
AE_mag_Runemasters_Dwarvish_Warrior
AE_mag_Runemasters_Flying_Fortress
AE_mag_Runemasters_Heavy_Balloon
AE_mag_Runemasters_Mechanic
AE_mag_Runemasters_Mechanical_Dragon
AE_mag_Runemasters_Pacificator
AE_mag_Runemasters_Parachutist
AE_mag_Runemasters_Runeadept
AE_mag_Runemasters_Runesmith
AE_mag_Runemasters_Steamcopter
AE_mag_Runemasters_Steam_Ulfserker
AE_mag_Runemasters_Striding_Machine
AE_mag_Sky_Kingdom_Abyss_Mage
AE_mag_Sky_Kingdom_Battlemage
AE_mag_Sky_Kingdom_Elementalist
AE_mag_Sky_Kingdom_Golden_Mage
AE_mag_Sky_Kingdom_Golem
AE_mag_Sky_Kingdom_Guru
AE_mag_Sky_Kingdom_Hidden_Face
AE_mag_Sky_Kingdom_Mage_of_Air
AE_mag_Sky_Kingdom_Mage_of_Fire
AE_mag_Sky_Kingdom_Mage_of_Water
AE_mag_Sky_Kingdom_Magical_Eye
AE_mag_Sky_Kingdom_Master_of_Elements
AE_mag_Sky_Kingdom_Master_of_Fire
AE_mag_Sky_Kingdom_Master_of_Water
AE_mag_Sky_Kingdom_Mu
AE_mag_Sky_Kingdom_Mystical_Warrior
AE_mag_Sky_Kingdom_Sculptor
AE_mag_Sky_Kingdom_Shadowmage
AE_mag_Sky_Kingdom_Sorcerer
AE_mag_Sky_Kingdom_Subversive_Mage
AE_mag_Sky_Kingdom_War_Mage
AE_mag_Tharis_Bladedancer
AE_mag_Tharis_Blademaster
AE_mag_Tharis_Commander
AE_mag_Tharis_Dark_Assassin
AE_mag_Tharis_Dark_Hunter
AE_mag_Tharis_Dark_Slayer
AE_mag_Tharis_Dark_Warrior
AE_mag_Tharis_Dark_Witch
AE_mag_Tharis_Dark_Wizard
AE_mag_Tharis_Disciple
AE_mag_Tharis_General
AE_mag_Tharis_Great_Hunter
AE_mag_Tharis_Great_Warlock
AE_mag_Tharis_Hydra
AE_mag_Tharis_Master_of_Darkness
AE_mag_Tharis_Master_of_War
AE_mag_Tharis_Matriarch_of_Darkness
AE_mag_Tharis_Matriarch_of_Emptiness
AE_mag_Tharis_Raging_Hydra
AE_mag_Tharis_Sworddancer
AE_mag_Tharis_Witch
AE_SaberCat
User avatar
Ravana
Moderator
 
Posts: 1447
Joined: January 29th, 2012, 12:49 am
Location: Estonia

Re: Feedback Thread for Xara's Add-ons

Postby Ravana » September 20th, 2017, 8:34 pm

After replacing EoMa faction prefixes, that list drops to
Code: Select all
AE_chs_chaos_empire_Arbalestier -- removed, gunner fills its role
AE_chs_chaos_empire_Assault_Drone -- moved to dark legion
AE_chs_chaos_empire_Bowman -- removed, gunner fills its role
AE_chs_chaos_empire_Crossbowman -- removed, gunner fills its role
AE_chs_chaos_empire_Drone -- moved to dark legion
AE_chs_chaos_empire_Heavy_Longbowman -- removed, gunner fills its role
AE_chs_chaos_empire_Longbowman -- removed, gunner fills its role
AE_chs_chaos_empire_Protector_Drone -- moved to dark legion
AE_chs_chaos_empire_Rayblade -- moved to dark legion
AE_chs_chaos_empire_Runner_Drone -- moved to dark legion
AE_chs_chaos_empire_Sentry_Drone -- moved to dark legion
AE_efm_dalefolk_shifter
AE_efm_dalefolk_Wilderman
AE_efm_seastates_Elite_Cataphract
AE_efm_seastates_Elite_MerchantLord
AE_LizardEye
AE_mag_Abyss_Mage
AE_mag_Battle_Toad
AE_mag_Cyclops_Destroyer
AE_mag_Dark_Witch
AE_mag_Efreeti
AE_mag_Mystical_Warrior
AE_mag_Plantium_Warrior
AE_mag_Revenger
AE_mag_Shaman_Adept
AE_mag_Shooter
AE_mag_War_Banner
AE_SaberCat
User avatar
Ravana
Moderator
 
Posts: 1447
Joined: January 29th, 2012, 12:49 am
Location: Estonia

Previous

Return to Add-on Feedback

Who is online

Users browsing this forum: No registered users and 2 guests