Unit XP-bar color-setting with custom AMLA's

[WhiteWolf]

Hello,

I am using some custom AMLA's in my campaign, very similarly to how it's done UtBS.

a few examples:

Code: Select all

    [advancement]
        id=warrior_1
        strict_amla=yes
        description= _ "1) Elite Warrior training: increase damage on all attacks, unlock specializations"
        image=attacks/sword-holy.png
        {HEAL_EFFECTS}
        [effect]
            apply_to=attack
            range=melee
            increase_damage=1
        [/effect]
        [effect]
            apply_to=attack
            range=ranged
            increase_damage=1
        [/effect]
    [/advancement]
    [advancement]
        id=warrior_2
        strict_amla=yes
		require_amla=warrior_1
        description= _ "1) Elite Warrior training, level 2: increase damage on all attacks"
        image=icons/crossed_sword_and_hammer.png
        {HEAL_EFFECTS}
        [effect]
            apply_to=attack
            range=melee
            increase_damage=2
        [/effect]
        [effect]
            apply_to=attack
            range=ranged
            increase_damage=2
        [/effect]
    [/advancement]
    [advancement]
        id=warrior_1_1
        strict_amla=yes
		require_amla=warrior_1
		exclude_amla=warrior_1_2
        description= _ "1a) Elite Warrior specialization (select one): specialize in advanced armor"
        image=icons/steel_armor.png
        {HEAL_EFFECTS}
        [effect]
            apply_to=resistance
			replace=no
			[resistance]
				blade=-10
				pierce=-10
				impact=-10
				cold=-10
				fire=-10
				arcane=-10
			[/resistance]
        [/effect]
    [/advancement]
    [advancement]
        id=warrior_1_2
        strict_amla=yes
		require_amla=warrior_1
		exclude_amla=warrior_1_1
        description= _ "1b) Elite Warrior specialization (select one): specialize in advanced technique"
        image=attacks/sword-steel.png
        {HEAL_EFFECTS}
        [effect]
            apply_to=attack
            range=melee
            increase_attacks=1
        [/effect]
        [effect]
            apply_to=attack
            range=ranged
            increase_attacks=1
        [/effect]
    [/advancement]

It functions well, however, all max-level units still have blue XP-bar. This is the same in UtBS as I checked.
However, I would like to indicate that the units are already max level and will only do AMLA's by using the standard purple XP-bar. In the wiki it doesn't say anything about this, and setting strict_amla=yes doesn't help. The default AMLA code doesn't have any extra setting that would imply the colour of the XP-bar.
So what makes it purple, and how do I get it to stay purple?

Thanks,
WhiteWolf

[Ravana]

I guess it depends on existence of advance_to in that unit.

[WhiteWolf]

As far as I know, it doesn't. For example, if you set advances_to=null, but omit {AMLA_DEFAULT} from a unit, the bar will be blue.
Also, judging from UtBS, Quenoth Youth has advances_to=null in its code, so it's definitely not that.

[enclave]

sorry for not being much helpful but im sure it's achievable somehow.. you just have to play around with variables REALLY a lot.. look [unit] tag and [unit_type] tags, all possible things to do with experience, amla and advancements..

my memory is crap, so i cant tell how, but im 99% certain i could do purple bars..
looking at some of my old code i found this: {VARIABLE new_unit_advancement[0].modifications.advance.strict_amla no}
i dont remember what exactly i was trying to achieve (could be the opposite of yours.. to remove purple bars from unit and give it blue one, i dont remember). So try to set advance_to=null (maybe nill), OR advances_to... strict_amla - YES
(I have no idea now why i used strict amla in MODIFICATIONS as my example shows.. browse some wiki help, maybe u find something uselful...)

there is a chance that you need to add modification to unit like so (just in your case strict_amla i assume would be YES):

Code: Select all

[modifications]
[advance]
id="ogre_leader_advancement"
description="Can advance into Ogre Leader"
strict_amla=no
always_display=true
require_amla=blabla
[/advance]
[/modifications]

or

Code: Select all

[modifications]
[advancement]
id="ogre_leader_advancement"
description="Can advance into Ogre Leader"
strict_amla=no
always_display=true
require_amla=blabla
[/advancement]
[/modifications]

but i can't tell if it's going to do anything for sure.. you have to try it..

best way is to use command line during local game, type there "debug" and then type "inspect" in command line as well (:debug :inspect), double dots open command line. In the inspection you can observe every unit array and see what variables you could modify (with [store_unit], [unstore_unit], or possibly [unit_type], [unit], depends on how you code your amlas etc), not all variables will be modifiable unfortunately.. but most will.

sorry for not telling you how exactly to solve your problem, because I do NOT know.. but just giving you some ideas if you despearate and nobody else able to solve your problem atm.

[Ravana]

There is major_amla https://github.com/wesnoth/wesnoth/comm ... t-26715656. Not sure how it works, but if it does something useful, you could add it to wiki.

[Lord-Knightmare]

I solved this problem two years ago. All you have to do is add {AMLA_DEFAULT} to your list of AMLA choices.

Spoiler:

Code: Select all

    {AMLA_DEFAULT}
    [+advancement]
        image="icons/amla-default.png"
    [/advancement]

#ifdef ENABLE_CUSTOM_AMLAS
    {AMLA_STRENGTH_I}
    {AMLA_STRENGTH_II}
    {AMLA_ENDURANCE_I}
    {AMLA_ENDURANCE_II}
    {AMLA_ENDURANCE_III}
    {AMLA_SUPERIOR_LEADERSHIP_I}
    {AMLA_SUPERIOR_LEADERSHIP_II}
#endif

It appears on the list, you can select it if you want...

XP bar after all buff AMLAs, the XP bar stays purple

Base Unit

[WhiteWolf]

I solved this problem two years ago. All you have to do is add {AMLA_DEFAULT} to your list of AMLA choices.

That's fine, but that's precisely what I wish to avoid, because I am not increasing the max XP with these. The default is there, but it has require_amla on all the custom ones.

enclave: I already tried most of those before posting
So, results: strict_amla and advances_to does nothing concerning this issue. major_amla does Apparently it defaults to yes, and if there is more than one [advancement] available with it, then the bar is blue. Setting them all to major_amla=no solves the issue and the bar is purple. I'll add this to the wiki then.

Thanks everyone

[Lord-Knightmare]

because I am not increasing the max XP with these

If that's the case why not use just a customised {AMLA_DEFAULT_UMC} that does not cause an increase in maximum XP?
If that is used, then the max_experience amount never increases pass the defined value in the unit.cfg file but just resets to zero after every upgrade.

[gfgtdf]

Setting them all to major_amla=no solves the issue and the bar is purple. I'll add this to the wiki then.

your wiki entry is not 100% currect though, it defaults to 'no'. If it ppears to true in the code you pasted above, then it's likeley that you acceindly wrote major_amla=yes somehere before, for exampel in the {HEAL_EFFECTS} macro.

[WhiteWolf]

because I am not increasing the max XP with these

If that's the case why not use just a customised {AMLA_DEFAULT_UMC} that does not cause an increase in maximum XP?
If that is used, then the max_experience amount never increases pass the defined value in the unit.cfg file but just resets to zero after every upgrade.

I wasn't precise enough - I only want to enable the default AMLA specifically after a unit completed its custom AMLA's and not before. For story reasons as well.

your wiki entry is not 100% currect though, it defaults to 'no'. If it ppears to true in the code you pasted above, then it's likeley that you acceindly wrote major_amla=yes somehere before, for exampel in the {HEAL_EFFECTS} macro.

And indeed I did Corrected that, sorry.