Bitrons WML Questions

[Dugi]

Ability code. Your code is almost correct.

There is an error that might be preventing it from working. The game cannot know what unit is to be affected by your object. Add this into its code to let it know:

Code: Select all

[filter]
  id=$inspired[$i].id
[/filter]

[Bitron]

Well, it still dont work :/

Code: Select all

[object]
    [filter]
        id=inspired[$i].id
    [/filter]
    silent=yes
    duration=turn
    [effect]
        increase_damage=1
        increase_accuracy=10
    [/effect]
[/object]

I also tried it within the [effect] block

[James_The_Invisible]

Add apply_to=attack to [effect] tag.

[Bitron]

oh thanks! but still...

here's the whole thing again:

Code: Select all

#define ABILITY_INSPIRATION
[dummy]
    id=inspiration
    name= _ "Inspiration"
    description=  _ "Inspires adjacent units and makes them faster and stronger."
[/dummy]

[/abilities]
    [event]
        name=turn refresh # After the normal restoration of movement
        first_time_only=no
        id=inspiration_movement_event
        [store_unit]
            [filter]
                [filter_adjacent] # Grab all units standing next to units with inspiration
                    ability=inspiration
                    [filter_side] # Don't get inspired by enemies
                        is_enemy=no
                    [/filter_side]
                [/filter_adjacent]
            [/filter]
            variable=inspired
        [/store_unit]
        {FOREACH inspired i} # Repeat this for every inspired unit
        {VARIABLE_OP inspired[$i].moves add 1} # Add 1 movement point to the moves restored to maximum
            [unstore_unit] # Return it back to the game
                variable=inspired[$i]
                find_vacant=no
            [/unstore_unit]
            [object]
                [filter]
                    id=inspired[$i].id
                [/filter]
                silent=yes
                duration=turn
                [effect]
                    apply_to=attack
                    increase_damage=1
                    increase_accuracy=10
                [/effect]
            [/object]
        {NEXT i}
        {CLEAR_VARIABLE inspired} # Clean up
    [/event]
[+abilities]
#enddef

[Dugi]

increase_accuracy= doesn't work. You have to add a [chance_to_hit] weapon special like the one I showed you in an earlier post. Without the [filter_self] tag. In [effect], you can add weapon specials using the [specials] tag with mode=append (as long as apply_to=attack). The increase_damage= part should work.

[James_The_Invisible]

increase_accuracy= doesn't work.

It should according to wiki. Yes, it was added there just a few months ago but it was in Wesnoth for ages.

[Dugi]

Oh, haven't noticed. Now I am quite clueless why it doesn't work. Maybe Bitron could tell us what does work and what doesn't.

[Bitron]

Well.. all units next to Inspirators are getting the extra movementpoint, but not the additional damage and also not the additional accuracy. (using the last-posted ability-code)

I'd guess that the Object simply doesn't reach the the inspired unit, maybe its the filter?

[Dugi]

:facepalm:
My bad.

Replace:
id=inspired[$i].id
with:
id=$inspired[$i].id

[Bitron]

Very well!, it works!
The inspired Unit gets +1 movementpoint, +1 Damage for Both ranged and melee, and +10% accuracy for both ranged and melee!

But, if a unit is already inspired and keep staying next to a Inspirator, the buff stacks within the opponents turn and resets to normal buff again in my turn after.

[Dugi]

Add side=$side_number into the first [filter] tag, as I wrote before.

[Bitron]

My implementation of the increased movement is not stackable. With an [object], you would have to be careful. The error that enemies inspire your units too can be fixed by replacing the part is_enemy=no by enemy_of=$side_number

Don't get inspired by enemies with Inspiration, or don't get inspired in the opponents turn?

[Dugi]

The quote pertains a different thing. Just add that side=$side_number into the first [filter] tag.

[Bitron]

ahh okay .. so just like this ?:

Code: Select all

[store_unit]
  [filter]
    side=$side_number
    [filter_adjacent] # Grab all units standing next to units with inspiration
      ability=inspiration
      [filter_side] # Don't get inspired by enemies
         is_enemy=no
      [/filter_side]
    [/filter_adjacent]
  [/filter]
  variable=inspired
[/store_unit]

[Dugi]

Yeah, that should be it.