Droid side while playing

[ChaosRider]

While playing some player decide to droid own side, who control side then? Or how to findout that there is no longer a human as a controller but ai? Im curious because in wml I can check it if ai is set from the start.

[pe_em]

You mean something like this?

Code: Select all

[modify_side]
    side=1
    controller=ai
[/modify_side]

Checking the controller (not very good but probably working):

Code: Select all

[store_side]
    side=1 #it's possible that it needs a filter_side tag
    variable=sidetocheck
[/store_side]
[switch]
    variable=sidetocheck.controller
    [case]
        value=ai
        #action
    [/case]
    #other cases if you need
    [else]
        #action
    [/else]
[/switch]

[ChaosRider]

Not much since I have code in which Im using already storing side and checking who is controller (human/ai), what's funny if I give there to works only when side is controlled by human (or ai) then I get oos, but I don't get oos when I set it for the opposite condition (not_equals=ai (for human sides), not_equals=human (for ai sides)), but this doesnt work when side started as a human player is droided later.

Spoiler:

Code: Select all

	[event]
		name=recruit,recall
		first_time_only=no
		id=add_units_classes_to_just_recruited
		[store_unit]
			[filter]
				x,y=$x1,$y1
			[/filter]
			kill=no
			variable=just_recruited_unit
		[/store_unit]
		[store_side]
		   side=$side_number
		   variable=this_side
		[/store_side]
		{VARIABLE unit_class_is_already_picked no}
		[if]
			[variable]
				name=this_side.controller
				not_equals=ai
			[/variable]
			[then]
				#here I have message options where human players are picking by self units classes
				{VARIABLE unit_class_is_already_picked yes}
			[/then]
		[/if]
		[if]
			[variable]
				name=unit_class_is_already_picked
				equals=no
			[/variable]
			[then]
				#here is automatic picking units classes
				{VARIABLE unit_class_is_already_picked yes}
			[/then]
		[/if]
		{CLEAR_VARIABLE just_recruited_unit.underlying_id,just_recruited_unit.id} 
		{CLEAR_VARIABLE just_recruited_unit,just_spawned_have_ranged_weapon,just_spawned_have_melee_weapon,unit_class_is_already_picked}
		{CLEAR_VARIABLE this_side}
	[/event]

Problem is when human player droid own side because my code is still asking him about picking unit class, but it shouldn't because I thought after droid side is changed controller from human to ai...

[Implementor37]

I'm assuming that by "droiding his own side" you are referring to a player entering the :droid command into Wesnoth itself, and not a WML script, right?
Anyway, that shouldn't really matter. Here's what i think is wrong:

Code: Select all

[variable]
 name=this_side.controller
 not_equals=ai
[/variable]

I believe should be:

Code: Select all

[variable]
 name=$this_side.controller #or should this be $this_side.controller| ?  I forget...
 not_equals=ai
[/variable]

Try that and see if it fixes the problem--i think you just forgot the variable operator ('$') and the pipeline character ('|')--which updates and imports the value of the variable.

[Ravana]

I'm assuming that by "droiding his own side" you are referring to a player entering the :droid command into Wesnoth itself, and not a WML script, right?
Anyway, that shouldn't really matter. Here's what i think is wrong:

Code: Select all

[variable]
 name=this_side.controller
 not_equals=ai
[/variable]

I believe should be:

Code: Select all

[variable]
 name=$this_side.controller #or should this be $this_side.controller| ?  I forget...
 not_equals=ai
[/variable]

Try that and see if it fixes the problem--i think you just forgot the variable operator ('$') and the pipeline character ('|')--which updates and imports the value of the variable.

Normally yes, but [variable] indeed wants name instead of value so original is correct. I have tried to get which sides are ai, but I never got anything reliable.

I have noted http://forums.wesnoth.org/viewtopic.php?f=21&t=41347 to try for this, but never had any further need for it. So try with wesnoth.synchronize_choice.

[iceiceice]

In 1.13 we changed how it works.

In future versions, when you droid a side, it will ask ai to make moves but it will not change the "controller" field and from the point of view of WML nothing will have changed.

We did this so that, if you droid a side and then win the game, it counts as a victory, since you are still *really* a human and not an ai.
Also if you save and reload the game, the droided sides will be human slots and not ai slots.

The controller field is used for a lot of things, it can change what events are fired, what the outcome of the scenario is, so you don't usually want to change it unless WML specifically asks for it.

When you :droid a side, that is supposed to mean "I am asking an AI to make moves for me, but it is still my side, I'm not trying to reconfigure the entire scenario". We might add a different command that means "There was a bug, this side is supposed to be AI / supposed to be human, I want to reconfigure the entire scenario", which will work like it did in 1.10 and 1.12.

[ChaosRider]

So in Wesnoth 1.10 (before 1.11 and higher) is there any way to catch the moment when human player droid own side (and undroid) to inform my code to threat this one side as ai side not human?

[iceiceice]

I don't think so... maybe with lua or something.

[ChaosRider]

Only way will be to add option (by right click) for each of players to change from manual picking for automatically picking units (only when first human player choose to allow them to pick unit classes by own (first human player can: a) unallow units classes, b) allow but only automatically picked, c) allows human players to choose it by own (but for ai sides its still b option))).

[Implementor37]

Maybe you could just put a warning message in the beginning of every scenario using your add-on saying something like

WARNING! Do not :droid your side. Doing so breaks the WML for this add-on.

instead of trying to figure out what to have the ai do with a :droid side.

[iceiceice]

I guess the alternatives are...

- Use the "ai_turn" event?
- Register a special AI stage with all sides that runs before the other stages, whose only purpose is that when their turn starts it fires a custom event you control? (This is pretty hacky.)

[ChaosRider]

Or other good option to have no problems with droiding will be to give human players time to pick unit class (by right click at unit) to the turn end, if they wont do this then at turn end it will get automatically.