Story of the Four Quotes""""

[NoQ]

Not sure if crashing the game with invalid WML is considered to be a bug, so not sure what to do, just wanted to report somehow.

First, i figured out that "" is the valid way to insert quote mark into a string.

Code: Select all

[story]
    [part]
        story= _ "And Delfador said: ""Hey, now I know how to insert quotes! That's awesome!"" ..."
    [/part]
[/story]

Then, i figured out that it works at the beginning or at the end of the string as well:

Code: Select all

[story]
    [part]
        story= _ """Yay, I can even quote the whole thing with this!"""
    [/part]
[/story]

That's it for the story so far.
Then, due to annoying auto-completion in my text editor, i made a typo:

Code: Select all

[story]
    [part]
        story= _ """"Gonna try to use more of this now."""
    [/part]
[/story]

And, trying to parse this, the game ran out of memory and got killed by the OOM killer
Took a while for me to find the typo. Probably a warning message could be useful.
Happened on both 1.10 and 1.11.

[Iris]

And, trying to parse this, the game ran out of memory and got killed by the OOM killer
Took a while for me to find the typo. Probably a warning message could be useful.

Invalid WML crashing the game is a bug. Invalid WML crashing your machine? Well...

Of course this is a bug, and it would be nice if you could report it in the tracker (per ReportingBugs) with more detailed information and a minimal test case. I appear to be unable to reproduce it on 1.11.15+dev, but that probably just means I’m missing something.

Note that if you need to insert a straight quote in contexts that accept Pango markup like [message] and [part], you should also be able to use " for that purpose:

Code: Select all

[message]
    speaker=narrator
    message=""Yay.""
[/message]

[8680]

In English text, typographical quotation marks (U+201C LEFT DOUBLE QUOTATION MARK and U+201D RIGHT DOUBLE QUOTATION MARK) can also be used:

Code: Select all

[message]
    speaker=narrator
    message= _ "“Hurrah.”"
[/message]

These have the comparative advantages of being (a) more legible than " and (b) not part of WML syntax, so they shouldn’t be able to crash the game (and, (c) the proper thing for English text).