Un-petrifying Petrified units and Vice Versa

[Lord-Knightmare]

Hello, I have been trying to make these macros work, but I cannot speculate what I have done wrong.

Code: Select all

[event]
      name="turn 6"
      {VARIABLE initiate_minotaurs yes}
   [/event]

   [event]
      name="new turn"
      first_time_only=no

      [if]
         {VARIABLE_CONDITIONAL initiate_minotaurs equals yes}
         [then]

            [filter_location]
                time_of_day=chaotic
            [/filter_location]
            [store_unit]
                [filter]
                    side=3
                [/filter]
                variable="minotaurs"
                kill=no
            [/store_unit]

            {FOREACH minotaurs i}
                {VARIABLE_OP minotaurs[$i] petrified no}
                [unstore_unit]
                    variable="minotaurs[$i]"
                    find_vacant=no
                [/unstore_unit]
            {NEXT i}

            {CLEAR_VARIABLE minotaurs}
         [/then]
      [/if]
      [if]
         {VARIABLE_CONDITIONAL initiate_minotaurs equals yes}
         [then]

            [filter_location]
                time_of_day=lawful
            [/filter_location]
            [store_unit]
                [filter]
                    side=3
                [/filter]
                variable="minotaurs"
                kill=no
            [/store_unit]

            {FOREACH minotaurs i}
                {VARIABLE_OP minotaurs[$i] petrified yes}
                [unstore_unit]
                    variable="minotaurs[$i]"
                    find_vacant=no
                [/unstore_unit]
            {NEXT i}

            {CLEAR_VARIABLE minotaurs}
         [/then]
      [/if]
   [/event]

2P_Minotaur_Battlefield v0.3.cfg

(12.32 KiB) Downloaded 149 times

Can anybody help me out ?

[pyrophorus]

Code: Select all

{VARIABLE_OP minotaurs[$i] petrified no}

The second parameter should be an operator name. I doubt 'petrified' being valid in this context.
Maybe you could use instead:

Code: Select all

{VARIABLE minotaurs[$i].status.petrified no}

HTH

[iceiceice]

This code would be significantly simpler if instead of storing and unstoring, you just use the [unpetrify] tag. There is also a corresponding [petrify] tag for vice versa.

[zookeeper]

Not to mention [filter_location] obviously isn't an action tag.

[Lord-Knightmare]

This code would be significantly simpler if instead of storing and unstoring, you just use the [unpetrify] tag. There is also a corresponding [petrify] tag for vice versa.

I started with that and it did not work and thus, I was compelled to make the code more sophisticated.

The second parameter should be an operator name. I doubt 'petrified' being valid in this context.
Maybe you could use instead:

I got these errors after I made your suggested edit.

Not to mention [filter_location] obviously isn't an action tag.

Then how shall I take the time of day into account in the coding?

[iceiceice]

So you might do things like:

Code: Select all

[unpetrify]
    side = 3
    [filter_location]
        time_of_day = lawful
    [/filter_location]
[/unpetrify]

If you are confused about why this is the code, the description of [petrify] says that it should take a standard unit filter as an argument, but you suppress the [filter] and [/filter] tags when using it. The unit filter you want also contains a filter based on location as an extra condition on the unit, so [filter_location] is a subsection of this unit filter.

In the above code you have structure

Code: Select all

IF initiate minotaurs
    unpetrify chaotic
ENDIF
IF initiate minotaurs
    unpetrify lawful
ENDIF

Clearly, you could just test once and unpetrify all...

Code: Select all

{IF_VAR initiate_minotaurs boolean_equals yes (
    [then]
        [unpetrify]
            side = 3
        [/unpetrify]
    [/then]
)}

unless for some reason you haven't shown us you want sometimes to unpetrify some and not others, and then you still need the location tests.

If e.g. side 3 controls some other statues on the map, which are at neutral locations and shouldn't be unpetrified, you might use something like

Code: Select all

{IF_VAR initiate_minotaurs boolean_equals yes (
    [then]
        [unpetrify]
            side = 3
            [filter_location]
                time_of_day = lawful
                [or]
                    time_of_day = chaotic
                [/or]
            [/filter_location]
        [/unpetrify]
    [/then]
)}

[Lord-Knightmare]

So you might do things like:

Thank you! It works now!

Now, to upload the add-on...

[JaMiT]

I started with that and it did not work and thus, I was compelled to make the code more sophisticated.

Well, your "more sophisticated" code did not work either, did it?

I got these errors after I made your suggested edit.

The first error message suggests you neglected to change VARIABLE_OP to VARIABLE.

I have no guess as to the cause of the second error, and since you have it working, I won't spend time on it.