Heindals WML Questions

[Heindal]

Hello,

Is it possible to check the "terrain type" of a coordinate and than save it in a variable? I need this for a random encounter, with changing maps.
I haven't found anything so far within the wiki and I'd appreciate your help.

Kind regards

Heindal

[Adamant14]

Try something like:

Code: Select all

	[store_locations]
		x,y=$x1,$y1
		variable=stored_terrain
	[/store_locations]

[Heindal]

Holy WML knowledge gap . This should work fine.

Thank you very much Adamant14 .

[Heindal]

Well, it doesn't work. I don't know what I'm doing wrong. The idea sounds simple.

Select the x,y coordinate of the herounit, check the terraintype and than call an encounter (each type of terrain is a scenario) that is based on the terrain type, for example a scenario within a desert, when the hero stands on a desert field.

My main problem is that the saved varriable "terrain" is always empty. I tried different approaches with filters, adding the hero id it won't work. Can anybody give me an advice?

Code: Select all

#define CALLENCOUNTER

[store_unit]
	[filter]
	   id=you
        	[/filter]
        	variable=younit
[/store_unit]

[set_variable]
	name=XHEROSPAWN
	value=$younit.x
[/set_variable]

[set_variable]
	name=YHEROSPAWN
	value=$younit.y
[/set_variable]

{CLEAR_VARIABLE younit}

[store_time_of_day]
x,y=$XHEROSPAWN,$YHEROSPAWN
variable=daytime
[/store_time_of_day]

[store_locations]
x,y=$XHEROSPAWN,$YHEROSPAWN
variable=terrain
[/store_locations]

[if]
[variable]
name=terrain
equals=Dd^Dc
[/variable]
[or]
[variable]
name=terrain
equals=Dd^Do
[/variable]
[/or]
[or]
[variable]
name=terrain
equals=Hd
[/variable]
[/or]
[or]
[variable]
name=terrain
equals=Md
[/variable]
[/or]
[then]
{CONTINUE Encounter5}
[/then]
[/if]
#enddef 

[Sapient]

terrain.terrain
It stores terrain inside the container variable


I would avoid naming a location variable as terrain to prevent this confusion, e.g. my_location.terrain

[Kernigh]

As a shortcut, you might remove [store_locations] and use [have_location].

Code: Select all

[if]
    [have_location]
        x,y=$XHEROSPAWN,$YHEROSPAWN
        terrain=Dd^Dc,Dd^Do,Hd,Md
    [/have_location]
    [then]
        # ...

[Heindal]

Thanks both of you! It works fine now. No I need to look up some terrain variables, but thanks to have location I can make a comma separated list, which should work fine and reduce the code. If anyone is interested in the code for the random encounter or the maps, I can post them later. It will be published in the new version of Strange Legacy.

[Heindal]

I have two other questions. At the moment I'm working on two macros.


The first macro should be simple range test, that will allows to use a attack, spell or ability over a greater range. The parts of the macro are placed within a spelloption and should test if the target is in range. At the moment it has no effect for some reason. The else part is buggy, but it seems that I'm blind. I can't find a mistake in the definition.

Spoiler:

Code: Select all

#define RANGETEST_START

 [store_unit]
      [filter]
        id=you
      [/filter]
        variable=firer
    [/store_unit]


[set_variable]
  name=testx
  value=$firer.x
[/set_variable]

[set_variable]
  name=texty
  value=$firer.y
[/set_variable]


[if]
	[variable]
		name=testx
		less_than_equal_to=$x1
	[/variable]
	[then]

	[set_variable]
		name=testx
		sub=$x1
	[/set_variable]
	[/then]
	[else]
	
	[set_variable]
		name=testx2
		value=$x1
	[/set_variable]
	
	[set_variable]
		name=testx2
		sub=$testx
	[/set_variable]
	
	[set_variable]
		name=testx
		value=$testx2
	[/set_variable]
	
	[/else]
[/if]


[if]
	[variable]
		name=testy
		less_than_equal_to=$y1
	[/variable]
	[then]

	[set_variable]
		name=testy
		sub=$y1
	[/set_variable]
	
	[/then]
	[else]
	
	[set_variable]
		name=testy2
		value=$y1
	[/set_variable]
	
	[set_variable]
		name=testy2
		sub=$testy
	[/set_variable]
	
	[set_variable]
		name=testy
		value=$testy2
	[/set_variable]
	
	[/else]
[/if]


            [if]
                [variable]
                    name=testx
                    less_than_equal_to=$range
                [/variable]
                [variable]
                    name=testy
                    less_than_equal_to=$range
                [/variable]
                [then]
                
#enddef 


#define RANGETEST_END

  [/then]
  [else]
  
  [message]
	speaker=you
	message= _ "This spot is out of range! My actual range is $range| tiles."
	[/message]
  
  [/else]
[/if]

{CLEAR_VARIABLE firer}
{CLEAR_VARIABLE testy}
{CLEAR_VARIABLE testx}

#enddef 

The second macro should place a trap (or a move to event) in a scenario.

Spoiler:

Code: Select all

[set_menu_item]
id=3
description="Set a Trap"
image=small/sharpshooter.png
[show_if]
		[have_unit]
			id=you
		[/have_unit]
		[variable]
			name=Trapbuilding
			equals=yes
		[/variable]
	[/show_if]
[command]
 
[set_variable] 
name=finished
value=no
[/set_variable]
 
 [while]
	[variable]
		name=finished
		equals=no
	[/variable]
	[do]
		[store_gold]
			side=1
			variable=gold
		[/store_gold]
  
		[message]
			speaker=you
			message= _ "<b>Which Trap do you want to set up? Gold: $gold|, Metal: $metal|, Force: $force|!</b>"

			{TRAPOPTION Spiketrap 10 10 0 animation/spikes.png}
			{TRAPOPTION Phasedoortrap 1 0 10 animation/phasedoor.png}
			{TRAPOPTION Icetrap 15 10 5 animation/slowcloud.png}
			{TRAPOPTION Poisontrap 20 0 0 animation/poisoncloud.png}
			{TRAPOPTION Explosiontrap 30 5 5 animation/explosion.png}

			[option]
				message= _ {MENU_IMG_TXT "icons/boots_elven.png" "Leave Traps!"}
				[command]
					[set_variable] 
						name=finished
						value=yes
					[/set_variable]
				[/command]
			[/option]
		[/message]
	[/do]
[/while]
[/command]
[/set_menu_item]

Code: Select all

#define TRAPOPTION NAME GOLD METAL FORCE PICTUREPATH

[option]
[show_if]
 [variable]
  name={NAME}
  equals=yes
 [/variable]
 [variable]
  name=gold
  greater_than_equal_to={GOLD}
 [/variable]
	[variable]
  name=metal
  greater_than_equal_to={METAL}
 [/variable]
  [variable]
  name=force
  greater_than_equal_to={FORCE}
 [/variable]
	[/show_if]
	message= _ {MENU_IMG_TXT "{PICTUREPATH}" "<b>Set {NAME} for Gold: {GOLD}, Metal: {METAL}, Force: {FORCE}!</b>"}
	[command]
	
	{RANGETEST_START}
  [sound]
  name=torch-miss.ogg
  [/sound]
  
  [message]
	speaker=you
	message= _ "You set up your {NAME}!"
	[/message]
 
	[gold]
	side=1
	amount=-{GOLD}
	[/gold]
 
 [set_variable]
 name=metal
 sub={METAL}
 [/set_variable]
 
 [set_variable]
 name=force
 sub={FORCE}
 [/set_variable]


 [set_variable]
 name=trapx
 value=$x1
 [/set_variable]

 [set_variable]
 name=trapy
 value=$y1
 [/set_variable]
 
 [set_variable]
 name=Trapname
 value={NAME}
 [/set_variable]
 

[switch]
    variable=Trapname
    [case]
       value="Spiketrap"
       {TRAP ($trapx) ($trapy) 5 None spear-miss.ogg Spikes}
    [/case]
    [case]
       value="Explosiontrap"
       {TRAP ($trapx) ($trapy) 20 None explosion.ogg Explosion}
    [/case]
	[case]
       value="Poisontrap"
       {TRAP ($trapx) ($trapy) 3 Poison poison.ogg Poison}
    [/case]
	[case]
       value="Icetrap"
       {TRAP ($trapx) ($trapy) 5 Slow entangle.wav Ice}
    [/case]
	[case]
       value="Phasedoortrap"
       {TRAP ($trapx) ($trapy) 0 Teleport lightning-miss.ogg White}
    [/case]
 [/switch]

 
[label]
x=$trapx
y=$trapy
text="{NAME}"
[/label]

{CLEAR_VARIABLE Trapname}
{CLEAR_VARIABLE trapx}
{CLEAR_VARIABLE trapy}
{RANGETEST_END}

[/command]
[/option]

#enddef 

It doesn't seem to work, the macro so far just places the label but not the event.

I tried two different approaches to solve the problem. I used $x1/$y1 and a random identifier togehter with trapx/trapy to define each coordinate as a unique variable. When using trapx/trapy + an identifier just the first trap seems to work when placing the second, it will have the second placed traps has the effect of two traps, while the first one is disarmed. $x1/$y1 each creature moving will be hurt by any placed trap. Any idea what's wrong with it?

[Ceres]

Code: Select all

[set_variable]
  name=texty
  value=$firer.y
[/set_variable]

I'm assuming that it should be testy, not texty.

[Max]

you need to learn to debug your code.

using :inspect (you have to enable debug mode, see http://wiki.wesnoth.org/CommandMode) would have revealed the variable mismatch (testx vs. textx).

if you're interested in certain variables directly within your code use [inspect]. it's also sometimes helpful to display messages to see what parts of your code are actually evaluated. you can use [message] or stick to the error macro http://www.wesnoth.org/macro-reference. ... -utils.cfg (just displays message in in-game chat and you don't have to discard lots of message windows).

your way to calculate the distance seems quite complicated, maybe something like that might help: http://forums.wesnoth.org/viewtopic.php ... 08#p481119

[pyrophorus]

Hi !
Why not this to test the range ?

Code: Select all

[have_unit]
	id=$firer.id
	[filter_location]
		x,y=$x1,$y1
		radius=$range
	[/filter_location]
	count=1
[/have_unit]

As for the trap event which don't work, did you checked 'delayed_variable_substitution=no' ?

HTH

[Heindal]

Thanks for your replies, as soon as I have time and motivation I will test all the proposals.
I'm sorry for not using debugging, I'm still using the game itself as validator.

[Heindal]

Thanks for your answers, I could solve both problems.
Pyrophorus posted solution for range works fine.

I also placed 'delayed_variable_substitution=no' in the event tag, where the map is created.
It works fine now! Thanks to you I could finish my work on "Dungeons of Wesnoth".

[Heindal]

Its me again:

I made several terrain overlays to place them within the map editor. It worked fine for some time but after adding more overlays I can not reload the map editor. I can open the game, but as soon as I try to open the map editor the game crashes. Is there a maximum of terrain overlays for a group?
Can adding terrains cause a crash?

[Alarantalara]

There is no maximum that I know of (you'd run out of space in "All" first anyway and Archaic Era already has a lot).
It's more likely that you have problems with your ids or terrain strings. Can you post a copy of the file containing all the terrain definitions?

You might also want to try removing other add-ons and trying again. You may have something that conflicts with it in an unusual way. If this is the case, including a list of the add-ons you have installed would also be useful.