Gloria Victis code issues

The place to post your WML questions and answers.

Moderators: Forum Moderators, Developers

Forum rules
  • Please use [code] BBCode tags in your posts for embedding WML snippets.
  • To keep your code readable so that others can easily help you, make sure to indent it following our conventions.
Ceres
Forum Regular
Posts: 620
Joined: September 18th, 2010, 7:56 pm
Location: Germany

Re: Gloria Victis code issues

Post by Ceres » January 7th, 2012, 10:14 pm

mattsc wrote:Another thing in you code snippet is that 'side' is not a valid key for [message] AFAIK.
[message] takes a SUF and side is therefore a valid key.

User avatar
Neuromancer
Posts: 204
Joined: September 10th, 2010, 9:49 pm

Re: Gloria Victis code issues

Post by Neuromancer » January 7th, 2012, 11:48 pm

Im trying to copy the units from side 1 to recall list of side 4, but it wont work.
Inspect command indicates there are copies created and their side is switched too, only the units are not in team 4 recall list. I use this code:

Code: Select all

	[store_unit]
		[filter]
			side=1
		[/filter]
		variable=copies
		kill=no
	[/store_unit]
     {FOREACH copies i}
	   {VARIABLE copies[$i].side 4}
	   [unstore_unit]
		  variable=copies[$i]
		  x,y=recall,recall
	   [/unstore_unit]
	   {NEXT i}

User avatar
Sapient
Inactive Developer
Posts: 4453
Joined: November 26th, 2005, 7:41 am
Contact:

Re: Gloria Victis code issues

Post by Sapient » January 8th, 2012, 6:34 am

Well the code looks right. Are you sure they're not in the recalls list?
If so, you might try putting this before [unstore_unit] :

{VARIABLE copies[$i].x recall}
{VARIABLE copies[$i].y recall}
http://www.wesnoth.org/wiki/User:Sapient... "Looks like your skills saved us again. Uh, well at least, they saved Soarin's apple pie."

User avatar
Neuromancer
Posts: 204
Joined: September 10th, 2010, 9:49 pm

Re: Gloria Victis code issues

Post by Neuromancer » January 8th, 2012, 9:10 am

Well, Im sure as far as inspect is sure. And am I assuming right AI-controlled sides with empty recruit field will try to recall?
I tried your piece of code, but it didnt work.
In attachment are zipped campaign files: to reproduce, start game on normal, pick random recruits and on world map go north into dried trees (they will be marked by icon). In that scenario, necrophage is leader of the side which wont recall.
Attachments
Gloria_Victis.zip
(3.19 MiB) Downloaded 101 times

mattsc
Posts: 1117
Joined: October 13th, 2010, 6:14 pm
Location: Hidden on the hex behind Fred

Re: Gloria Victis code issues

Post by mattsc » January 8th, 2012, 4:29 pm

I haven't downloaded and checked out your campaign file, but could you try something? Put "persistent=yes" into the side definition of Side 4 for this scenario (I assume that this is an AI controlled side?) and see if it works then. I think (maybe I misremember and am saying something stupid; again ;)) I've encountered it before that I cannot put units on a side's recall list that isn't persistent (i.e. either player controlled or with the parameter set specifically), but I haven't done enough research yet to figure out whether that is always like that or just for the cases I have tried (and whether it's supposed to work that way or not).

EDIT: Well, thinking about it, that does make some sense. Why would a non-persistent side need a recall list - under normal circumstances at least? But I still don't know whether it is implemented that way. It's probably documented somewhere, but I don't have time to look for it right now.

User avatar
Neuromancer
Posts: 204
Joined: September 10th, 2010, 9:49 pm

Re: Gloria Victis code issues

Post by Neuromancer » January 8th, 2012, 6:22 pm

It... actually works! Thanks a lot!

User avatar
Neuromancer
Posts: 204
Joined: September 10th, 2010, 9:49 pm

Re: Gloria Victis code issues

Post by Neuromancer » February 1st, 2012, 8:57 pm

This should be the last set of questions. The scenarios are done now - except for a few parts which needs tweaking:

1. I'm trying to insert animated fountain, but engine tells me [terrain_graphics] is not supported:

Code: Select all

    [terrain_graphics]
        x={X}
        y={Y}
        [tile]
            x=0
            y=0
            [image]
                layer=0
                name="../scenery/fountain-animated-1.png:140,../scenery/fountain-animated-2.png:140,../scenery/fountain-animated-3.png:140,../scenery/fountain-animated-4.png:140"
            [/image]
        [/tile]
    [/terrain_graphics]
2. This code stores units of side 1 and changes some of their variables, so they can be recruited by another side. How to change their IDs?

Code: Select all

	[store_unit]
		[filter]
			side=1
			[not]
				id=Hazael
			[/not]
		[/filter]
		variable=copies
		kill=no
	[/store_unit]
     {FOREACH copies i}
	   {VARIABLE copies[$i].side 4}
	   {VARIABLE copies[$i].canrecruit no} 
	   {VARIABLE copies[$i].x recall}
	   {VARIABLE copies[$i].y recall}
	   [unstore_unit]
		  variable=copies[$i]
		  x,y=recall,recall
	   [/unstore_unit]
	   {NEXT i}
As always, sincere thank you for all your answers.

User avatar
artisticdude
Moderator Emeritus
Posts: 2424
Joined: December 15th, 2009, 12:37 pm
Location: Somewhere in the middle of everything

Re: Gloria Victis code issues

Post by artisticdude » February 2nd, 2012, 3:07 pm

For the first problem, you are including the code at scenario toplevel, correct?

For the second, the unit's id is automatically stored when you use [store_unit] (which you can see using the debug command :inspect ). To change the id of the unit, you need to modify the variable id within the container copies[$i], like so:

Code: Select all

{VARIABLE copies[$i].id This_is_the_new_id}
"I'm never wrong. One time I thought I was wrong, but I was mistaken."

Morath
Posts: 22
Joined: August 24th, 2009, 12:38 am

Re: Gloria Victis code issues

Post by Morath » February 17th, 2012, 5:59 pm

mattsc wrote:This event fires, but only when Side 1 captures a village, that is owner_side contains the side which does the capture, not the previous owner side as it says at EventWML. Furthermore, the owner_side variable displayed both by [inspect] and in the message is always 0. So unless I misunderstand something here, this looks like a bug to me.
I can confirm the occurence of the $owner_side variable being 0 in a multiplayer campaign I am developing for version 1.10.0 when according to the documentation http://wiki.wesnoth.org/EventWML it shouldn't be. At least I feel more confident that I have not made a mistake somewhere. I have attached the (messy) scenario I am working on that has some debugging messages if it helps. Time for me to write a work-around for this bug.
Attachments
Silaric_Odyssey-owner-side.7z
(182.63 KiB) Downloaded 86 times

User avatar
Neuromancer
Posts: 204
Joined: September 10th, 2010, 9:49 pm

Re: Gloria Victis code issues

Post by Neuromancer » September 27th, 2013, 8:30 pm

Time to finish this campaign. You were great help before, could you help me again?

In one scenario, player is advancing into forest where hostile woses have settled. When players unit stumbles onto one, I want him/her to say something. I chose to use sighted event, because (if I understood correctly) from 1.11. it should work with units with hides ability. Im using version 1.11.6. Player is side 1, woses are 3. This code does nothing:

Code: Select all

[event]
	name=sighted
	[filter]
		side=3
	[/filter]
    [filter_second]
		side=1
    [/filter_second]
	   [message]
		   speaker=second_unit
		   message= _ "<i>Gasp!</i>"
	   [/message]
[/event]
Another situation is when heroes are escaping into cave, one by one. Its done by moveto event, which stores, then kills every unit which steps on the specified tile. When there are only 2 units left, one on the field and one entering the cave, I want the one entering the cave say something like "Hey $last_unit, quickly to the caves!" How to store that one unit into the $last_unit variable?

User avatar
pyrophorus
Posts: 513
Joined: December 1st, 2010, 12:54 pm

Re: Gloria Victis code issues

Post by pyrophorus » September 28th, 2013, 8:03 am

Hi !
I would use a 'moveto' event instead with a filter_adjacent tag describing the hiding wose. (Or even a new 'enter' tag, but I never used them).

HTH
Campaign Return to Noelren *** HowTos: WML filtering, WML variables
Please help to to update the Guide to UMC Campaigns

JaMiT
Developer
Posts: 511
Joined: January 22nd, 2012, 12:38 am

Re: Gloria Victis code issues

Post by JaMiT » September 29th, 2013, 1:52 am

Neuromancer wrote:I chose to use sighted event, because (if I understood correctly) from 1.11. it should work with units with hides ability.
You understand perfectly. Feel free to put emphasis on "should" -- apparently some idiot forgot to actually implement that aspect when I was fixing up the sighted events. It'll be in 1.11.7 (and in trunk by the end of the weekend, possibly within an hour or so, in case you want it faster ).

Well, ambush will be fixed. I might have to update the documentation to say that nightstalking units do not get a sighted event at the end of a night's last turn.

Neuromancer wrote:How to store that one unit into the $last_unit variable?
Perhaps:

Code: Select all

    {STORE_UNIT_VAR (
        # Assuming side 1 is the side with two units left:
        side=1
        # Not the unit who triggered this moveto event.
        [not]
            id=$unit.id
        [/not]
        ) name last_unit_name}
I changed the variable name because "last_unit" suggests it holds an entire unit, but that would not go with your use of "$last_unit", which suggests the variable holds just the unit's name.

Post Reply