Help coding 'ricochet' weapon special.

[someone]

I'm trying to code a special attack for personal use, but I've run into an unknown problem in my code while trying to test it.
The error details reads "Missing closing tag for tag unstore_unit" but as far I can tell that isn't the problem at all.
The attack has a weapon special called ricochet that is supposed to cause the attack to have a chance to damage more units if it hits initially. The problem is most likely in this area of code:

Spoiler:

Code: Select all

[event]
    name=attacker hits
    first_time_only=no
    [filter_attack]
        name=Energy Shield
    [/filter_attack]
    [set_variable]
        name=ifhits
        rand=hit,miss
    [/set_variable]
    [if]
        [variable]
            name=ifhits
            equals=hit
        [/variable]
        [then]
            [if]
                [have_unit]
                    count=2-7
                    [filter_location]
                        x,y=$x2,$y2
                        radius=1
                    [/filter_location]
                    [not]
                        side=$unit.side
                    [/not]
                [/have_unit]
                [then]
                    [store_unit]
                        [filter]
                            [filter_location]
                                x,y=$x2,$y2
                                radius=1
                            [/filter_location]
                            [not]
                                [filter_location]
                                    x,y=$x2,$y2
                                [/filter_location]
                            [/not]
                            [not]
                                side=$unit.side
                            [/not]
                        [/filter]
                        variable=shieldtargetb
                    [/store_unit]
                    [set_variable]
                        name=shieldtargetb.hitpoints
                        sub=8
                    [/set_variable]
                    [move_unit_fake]
                        type=capshield
                        x=$x2|,$shieldtargetb.x|
                        y=$y2|,$shieldtargetb.y|
                    [/move_unit_fake]
                    [unstore_unit]
                        variable=shieldtargetb
                        text=8
                        {COLOR_HARM}
                    [/unstore_unit]
                    {CAP_SHIELD_RICOCHET_A}
                [/then]
                [else]
                    [move_unit_fake]
                        type=capshield
                        x=$x2|,$x1|
                        y=$y2|,$y1|
                    [/move_unit_fake]
                [/else]
            [/if]
        [/then]
        [else]
            [move_unit_fake]
                type=capshield
                x=$x2|,$x1|
                y=$y2|,$y1|
            [/move_unit_fake]
        [/else]
    [/if]
[/event]

Code: Select all

#define CAP_SHIELD_RICOCHET_A
[set_variable]
    name=ifhits
    rand=hit,miss
[/set_variable]
[if]
    [variable]
        name=ifhits
        equals=hit
    [/variable]
    [then]
        [if]
            [have_unit]
                count=2-7
                [filter_location]
                    x,y=$shieldtargetb.x,$shieldtargetb.y
                    radius=1
                [/filter_location]
                [not]
                    side=$unit.side
                [/not]
            [/have_unit]
            [then]
                [clear_variable]
                    name=shieldtargeta
                [/clear_variable]
                [store_unit]
                    [filter]
                        [filter_location]
                            x,y=$shieldtargetb.x,$shieldtargetb.y
                            radius=1
                        [/filter_location]
                        [not]
                            [filter_location]
                                x,y=$shieldtargetb.x,$shieldtargetb.y
                            [/filter_location]
                        [/not]
                        [not]
                            side=$unit.side
                        [/not]
                    [/filter]
                    variable=shieldtargeta
                [/store_unit]
                [set_variable]
                    name=shieldtargeta.hitpoints
                    sub=8
                [/set_variable]
                [move_unit_fake]
                    type=capshield
                    x=$shieldtargetb.x|,$shieldtargeta.x|
                    y=$shieldtargetb.y|,$shieldtargeta.y|
                [/move_unit_fake]
                [unstore_unit]
                    variable=shieldtargeta
                    text=8
                    {COLOR_HARM}
                [/unstore_unit]
            [/then]
            [else]
                [move_unit_fake]
                    type=capshield
                    x=$shieldtargetb.x|,$x1
                    y=$shieldtargetb.y|,$y1
                [/move_unit_fake]
                {CAP_SHIELD_RICOCHET_B}
            [/else]
        [/if]
    [/then]
    [else]
        [move_unit_fake]
            type=capshield
            x=$shieldtargetb.x|,$x1
            y=$shieldtargetb.y|,$y1
        [/move_unit_fake]
    [/else]
[/if]
#enddef

#define CAP_SHIELD_RICOCHET_B
[set_variable]
    name=ifhits
    rand=hit,miss
[/set_variable]
[if]
    [variable]
        name=ifhits
        equals=hit
    [/variable]
    [then]
        [if]
            [have_unit]
                count=2-7
                [filter_location]
                    x,y=$shieldtargeta.x,$shieldtargeta.y
                    radius=1
                [/filter_location]
                [not]
                    side=$unit.side
                [/not]
            [/have_unit]
            [then]
                [clear_variable]
                    name=shieldtargetb
                [/clear_variable]
                [store_unit]
                    [filter]
                        [filter_location]
                            x,y=$shieldtargeta.x,$shieldtargeta.y
                            radius=1
                        [/filter_location]
                        [not]
                            [filter_location]
                                x,y=$shieldtargeta.x,$shieldtargeta.y
                            [/filter_location]
                        [/not]
                        [not]
                            side=$unit.side
                        [/not]
                    [/filter]
                    variable=shieldtargetb
                [/store_unit]
                [set_variable]
                    name=shieldtargetb.hitpoints
                    sub=8
                [/set_variable]
                [move_unit_fake]
                    type=capshield
                    x=$shieldtargeta.x|,$shieldtargetb.x|
                    y=$shieldtargeta.y|,$shieldtargetb.y|
                [/move_unit_fake]
                [unstore_unit]
                    variable=shieldtargetb
                    text=8
                    {COLOR_HARM}
                [/unstore_unit]
            [/then]
            [else]
                [move_unit_fake]
                    type=capshield
                    x=$shieldtargeta.x|,$x1
                    y=$shieldtargeta.y|,$y1
                [/move_unit_fake]
                {CAP_SHIELD_RICOCHET_A}
            [/else]
        [/if]
    [/then]
    [else]
        [move_unit_fake]
            type=capshield
            x=$shieldtargeta.x|,$x1
            y=$shieldtargeta.y|,$y1
        [/move_unit_fake]
    [/else]
[/if]
#enddef

[A Guy]

At a glance, I can't notice any errors with [unstore_unit] tags. Would you mind posting the stderr.txt?

[Max]

a macro isn't a function call. the way (looks unnecessarily complicated anyway) you use CAP_SHIELD_RICOCHET_A and CAP_SHIELD_RICOCHET_B results in an infinite recursion...

[someone]

@Max: Do you think the loop is causing the error? I'm not sure how else to make it work.

@A Guy: How do I find the stderr.txt? I'm using a Mac btw.

[A Guy]

stderr.txt should be in the main folder for Wesnoth.

[8680]

How do I find the stderr.txt? I'm using a Mac btw.

To see stderr messages on a Mac:
- Open Wesnoth by control clicking and choose "show package contents"
- Open the "Macintosh" folder. Inside are two terminal scripts, drag the one named Wesnoth to your dock and click it to launch the game every time
- Terminal will open and then launch Wesnoth
- stderr messages will be in Terminal.

Another way to view the stderr messages on a Mac is to use the Console application in /Applications/Utilities
All stderr messages that aren't displayed in Terminal using boru's method are logged in the Console Messages log (you may need to show the log list to find it). This will let you see messages even if you forget to start it boru's way.

[Max]

@Max: Do you think the loop is causing the error? I'm not sure how else to make it work

yes.
here's whats happening:

the preprocessor reads your event, comes to the place where you use CAP_SHIELD_RICOCHET_A. it get's replaced with the contents of that macro. inside that macro you use CAP_SHIELD_RICOCHET_B. this again is replaced with the contents, now there's CAP_SHIELD_RICOCHET_A inside CAP_SHIELD_RICOCHET_B and so on.
usually you run out of memory or there's a stack overflow. not sure why it's not crashing. maybe there's a hardcoded limit somewhere.

looking at your code (correct me if i'm wrong) i guess that's what your trying to do:
if a unit is hit there's a 50% chance that an adjacent unit of the same side might get hit.

- use a while loop (as long as there are units to process and your special didn't miss)
(to know we've processed a unit we can set a unit variable. see http://wiki.wesnoth.org/SingleUnitWML)
- store adjacent unit (range=1, x,y of last unit, side!=attacker, [filter_wml] for our unit variable, see above).
(remember that [store_unit] can store more than one unit, we'll use the first one only)
- set a unit variable so we know we've processed that unit

[someone]

Can an [while] tag include an else tag?

[Crendgrim]

ConditionalActionsWML#while
No.
Assuming the wiki is right, you'll have to use an independent [if] construct.


Crend

[someone]

So, I tried reworking it using the [while] tag, and here's what I came up with:

Spoiler:

Code: Select all

[event]
    name=attacker hits
    first_time_only=no
    [filter_attack]
        name=Energy Shield
    [/filter_attack]
    [clear_variable]
        name=shieldtargeta,shieldtargetb,ifhits
    [/clear_variable]
    [store_unit]
         [filter]
              x,y=$x2,$y2
         [/filter]
         variable=shieldtargeta
    [/store_unit]
    [set_variable]
        name=ifhits
        rand=hit,hit,hit,miss
    [/set_variable]
    [while]
        [variable]
            name=ifhits
            equals=hit
        [/variable]
        [do]
            [if]
                [have_unit]
                    count=2-7
                    [filter_location]
                        x,y=$shieldtargeta.x,$shieldtargeta.y
                        radius=1
                    [/filter_location]
                    [not]
                        side=$unit.side
                    [/not]
                [/have_unit]
                [then]
                    [store_unit]
                        [filter]
                            [filter_location]
                                x,y=$shieldtargeta.x,$shieldtargeta.y
                                radius=1
                            [/filter_location]
                            [not]
                                [filter_location]
                                    x,y=$shieldtargeta.x,$shieldtargeta.y
                                [/filter_location]
                            [/not]
                            [not]
                                side=$unit.side
                            [/not]
                        [/filter]
                        variable=shieldtargetb
                    [/store_unit]
                    [set_variable]
                        name=shieldtargetb.hitpoints
                        sub=8
                    [/set_variable]
                    [move_unit_fake]
                        type=capshield
                        x=$shieldtargeta.x|,$shieldtargetb.x|
                        y=$shieldtargeta.y|,$shieldtargetb.y|
                    [/move_unit_fake]
                    [unstore_unit]
                        variable=shieldtargetb
                        text=8
                        {COLOR_HARM}
                    [/unstore_unit]
                    [clear_variable]
                        name=shieldtargeta
                    [/clear_variable]
                    [store_unit]
                        [filter]
                            x,y=$shieldtargetb.x|,shieldtargetb.y|
                        [/filter]
                        vartiable=shieldtargeta
                    [/store_unit]
                    [if]
                        [variable]
                            name=shieldtargetb.hitpoints
                            less_than_equal_to=0
                        [/variable]
                        [then]
                            [kill]
                                id=$shieldtargetb.id
                                fire_event=yes
                                animate=yes
                            [/kill]
                        [/then]
                    [/if]
                    [clear_variable]
                        name=shieldtargetb,ifhits
                    [/clear_variable]
                    [set_variable]
                        name=ifhits
                        rand=hit,hit,hit,miss
                    [/set_variable]
                [/then]
            [/if]
        [/do]
    [/while]
[/event]

But, when the attack tries to hit a third target, the game stops responding.

[Max]

that's because you've create an infinite loop somehow (that's an improvement compared to infinite recursion^^)

use debug messages to see why this is happening.