halbArdier/halbErdier confusion

Discussion among members of the development team.

Moderators: Forum Moderators, Developers

Post Reply
Taurus
Inactive Developer
Posts: 674
Joined: May 4th, 2005, 8:16 pm
Location: Canada

halbArdier/halbErdier confusion

Post by Taurus » August 3rd, 2007, 4:17 pm

Is there any specific reason why the ID of the Halberdier is spelt 'Halbardier' while the name is "Halberdier"? If not, then is there any objection to me setting it strait?
Creater of the campaign, "Northern Rebirth"

Compleater of the campaign, "Son of the Black Eye"

User avatar
zookeeper
WML Wizard
Posts: 9739
Joined: September 11th, 2004, 10:40 pm
Location: Finland

Post by zookeeper » August 3rd, 2007, 6:11 pm

No reason. A while back I noticed that in mainline campaigns Halbardier was often spelled as Halberdier, causing quite a lot of recruit lists and such to be broken. However, I fixed all instances of Halberdier to Halbardier instead of vice versa and fixing the unit id, since I figured quite a lot of UMC might use Halbardier.

If you wish to change it to Halberdier, feel free to do so.

User avatar
Elvish_Pillager
Posts: 8129
Joined: May 28th, 2004, 10:21 am
Location: Everywhere you think, nowhere you can possibly imagine.
Contact:

Re: halbArdier/halbErdier confusion

Post by Elvish_Pillager » August 3rd, 2007, 11:27 pm

Taurus wrote:Is there any specific reason why the ID of the Halberdier is spelt 'Halbardier' while the name is "Halberdier"?
Yes. Historical reasons, mainly.

Originally, both the ID and the name were "Halbardier", until someone pointed out that that wasn't actually a word - it's just a misspelling of Halberdier. At that time in Wesnoth development, breaking savegame compatibility was a big issue, so it wasn't such a good idea to change the unit ID. In the pursuant discussion, some genius suggested that we change just the name and not the ID, so that's what was done.
Taurus wrote:If not, then is there any objection to me setting it strait?
It should have been done long ago.
It's all fun and games until someone loses a lawsuit. Oh, and by the way, sending me private messages won't work. :/ If you must contact me, there's an e-mail address listed on the website in my profile.

User avatar
Noyga
Inactive Developer
Posts: 1790
Joined: September 26th, 2005, 5:56 pm
Location: France

Post by Noyga » August 4th, 2007, 9:34 am

Just fixed in SVN so the 1.3.7 id will be "Halberdier' :)
"Ooh, man, my mage had a 30% chance to miss, but he still managed to hit! Awesome!" ;) -- xtifr

User avatar
Jetrel
Art Director
Posts: 7241
Joined: February 23rd, 2004, 3:36 am
Location: Midwest US

Post by Jetrel » August 4th, 2007, 10:38 am

Noyga wrote:Just fixed in SVN so the 1.3.7 id will be "Halberdier' :)
Excellent. That's the correct spelling.

Post Reply