a small feature request..

Discussion of all aspects of multiplayer development: unit balancing, map development, server development, and so forth.

Moderator: Forum Moderators

Post Reply
enclave
Posts: 936
Joined: December 15th, 2007, 8:52 am

a small feature request..

Post by enclave »

Hello great developers of wesnoth. I have a small feature request since wesnoth 1.14 works a bit different from 1.12 regarding replays and messages.. In 1.14 when you watch replays you see all messages ([message] side_for=) for all players.. I'm quite sure in 1.12 you would only see what normal observer would see, - messages without side_for tag in them.. Anyway..

My little feature request is, could you please make an option to tick "skip messages" during replay, like you have "skip animation"?

please look an example replay of my add-on, it's just unwatchable.. (after turn 3 gets worse and worse)
kraft, elder, dark, me t16.gz
(417.71 KiB) Downloaded 392 times

Thank you for your time.

PS. i know that I could just add [option] OK for each message. This would allow me to watch replays without messages, but it would annoy players who would now need to click in particular place (OK button) instead of just anywhere..
gfgtdf
Developer
Posts: 1432
Joined: February 10th, 2013, 2:25 pm

Re: a small feature request..

Post by gfgtdf »

i shouldn't be too hard to implement this in lua/wml, as soon as you know how to figure out how to check whetehr you are in a replay you can do something like

Code: Select all

function is_replay()
  ...
end
function wesnoth.wml_actions.noreplay_message(cfg)
  if not is_replay() then
    wesnoth.wml_actions.message(cfg)
  end
end
which adds a new [noreplay_message] tag, note that this will break when used with messages that have [option]s.

To figue out whether you are in a replay or not my first attempt would be to use [get/set_global_variable] in a unsynced block ([unsynced] or wesnoth.unsynced()) since set_global_cariable will be ignored during replay. (use set + get and if you got what you just set you are not in a replay, don't forget to clear afterwards). Maybe there is an even simpler way not sure.
Scenario with Robots SP scenario (1.11/1.12), allows you to build your units with components, PYR No preperation turn 1.12 mp-mod that allows you to select your units immideately after the game begins.
User avatar
Pentarctagon
Project Manager
Posts: 5531
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: a small feature request..

Post by Pentarctagon »

It would be best to open an issue here.
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code
enclave
Posts: 936
Joined: December 15th, 2007, 8:52 am

Re: a small feature request..

Post by enclave »

Couple questions/ideas:
a) Could [message] tag have an additional value/variable that would display message in the taskbar of the desktop?
for example wesnoth currently gives message/notification in taskbar/tray when it's players turn, or when somebody mentions your name or if ally starts the chat.. it gets displayed in bottom right corner of screen. Could it be customized for add-ons? If I have message on turn refresh then I dont get turn bell and I dont get taskbar/tray notification. So would be great to be able to add one.. like [message] notification="Research complete" [/message]
Or is it done already somehow? Sorry if i missed it.

b) The other thing is that replay server ( http://replays.wesnoth.org/1.14/20181128/ ) displays a huge number of random names as player names if the game was reloaded: title: kraftherz’s game era: HCiv players: Hagwylyn, Elyr, Marthynaent, ʿIkriras, , , Wakiwah, Derrogin, Default AI (RCA) 1, , , , Varreddin, Suraevan, Elyr, , Aeraery, , Meralyn, , Razbi, , Meoroc, Ronin, Aeran, Vygwyryn, , Nibwah, , Anyc, , Eler, , Citharran, , Gogwylyn, Meoraryn, Alyn, Marreoryr, Huthyc, Cetharran, Yrreddyr, , Elec, , Alyn, , Iran, Saranyc, Hellyn, , Innoc, , Owreddec, , Vinreoryr, , Bluraeryn, , Elec, Rhegwynyc, , Synnyr, , Varreorer, , Gaennin, , Cyvan, , Haddin, , Deovan, Leran, Taegwyryn, Vugthynaent, , Ilyn, , Aery, , Default AI (RCA) 2, , Yrreoryr, , Guvan, , Gory, , , Raeran, , Guraenyc, Default AI (RCA) 3, Arcer, Syry, Aryn, , Default AI (RCA) 4, Veotharlyn, , Blaeranyc, , , Rharaeryn, Lonnoc, , Madogyc, , Vinreddaent, Bury, , Suralyn, , Maroger, , Aeraery, Yddaent, , Luraevan, , Aryn, , Blaeralyn, , , Vinreorer, , , , Rethyn, Aethyr, Ritharran, Deoddyc, , Rhaegwynyc, , Cyry, , Elaent, Ynyc, Elec, Dyvan, Gwotharry, Denreoryr, Muranyc, Inyc, Default AI (RCA) 5, , Catharran, Vonyn, Rhogwynyc, Awer, Yrreoryr, Inec, Heovan, Haran, Elyn, Idyr, Owthynec, Anyc, Vobthynaent, Yroger, Raeryn, Gleraevan, Iller, Marthyner, Tivan, Vobreddyr, Toti, Rotharvan, Vugreddyn, Vugreddyn, Teotharran, Rhuddin, , Eryn, Owreoryr, Dugwynyc, Marreoryn, Bury, , kraftherz, , , , , Aellyr, Gumreddoc, , Baran, , Roddyc, Liraevan, Dowin, Aegwyran, Awoc
Not sure if it could be changed, but would be really really nice..
User avatar
Ravana
Forum Moderator
Posts: 2952
Joined: January 29th, 2012, 12:49 am
Location: Estonia
Contact:

Re: a small feature request..

Post by Ravana »

b) is obviously bug, you could report it properly.
enclave
Posts: 936
Joined: December 15th, 2007, 8:52 am

Re: a small feature request..

Post by enclave »

Ravana wrote: November 28th, 2018, 8:01 pm b) is obviously bug, you could report it properly.
I have a feeling it possibly stores all king names that were used during game.. but it's just a guess..
Post Reply