The Curse of Satan Claus

[Choicerer]

bugreport, when playing on the current latest version (1.4.0c, if I'm not mistaken (or maybe 1,4,0b, not sure)) satan doesn't spawn on the turn he should, and instead the following error message appears in the chat:

error.png

Thanks! Can you provide more info so I can recreate the bug, as all is in order here.

[ForestDragon]

Thanks! Can you provide more info so I can recreate the bug, as all is in order here.

could you specify what exact details do you need?

[Choicerer]

The map, the turn on which Satan was set to spawn. Any units in the centre of the map?

[ForestDragon]

The map

Hamlets 2p. reproduceable on any other map too.

the turn on which Satan was set to spawn.

happens with any selected turn.

Any units in the centre of the map?

none. the previous version (1.3.x) worked fine for me. if you have a backup, maybe check what changed since them?

[Choicerer]

Okay, it's not happening here. What are the settings you are using (slider positions)?

[ForestDragon]

Okay, it's not happening here. What are the settings you are using (slider positions)?

max available hp/damage/strikes, turn 1, restrictions 3, and impassable terrain on (though I doubt these the cause. the more likely reason would be a typo in the code)

[Choicerer]

Omg, yes, now I remember. I've already encountered the bug before, but forgot to fix it. It's actually caused by the number of strikes (5). You didn't get it before because the slider didn't work. 1.4b fixed the slider, previously it used to always be 3 no matter what you'd set. Apparently the max allowed number of strikes you can set is 4. Time for bugfix c. Thanks for the heads-up.

[ForestDragon]

Omg, yes, now I remember. I've already encountered the bug before, but forgot to fix it. It's actually caused by the number of strikes (5). You didn't get it before because the slider didn't work. 1.4b fixed the slider, previously it used to always be 3 no matter what you'd set. Apparently max allowed number of strikes you can set is 4. Time for bugfix c. Thanks for the heads-up.

glad to help!

[ForestDragon]

EDIT: oddly enough, the same bug still persists even in the fixed version, with the same error message (and not matter the amount of strikes I select)

[Choicerer]

Yes, damage set to more than 9 causes it, too. I'll fix it shortly.

[ForestDragon]

some more ideas for the mod:
-you can give satan 50% defense on impassable terrain by using the following effect inside an [object] (right now his ability to pass though walls can be exploited in some cave maps due to his having 0% defense in the walls):

Code: Select all

        [effect]
            apply_to=defense
            replace=true
            [defense]
                impassable=50
            [/defense]
        [/effect]

-you can change satan's profile image to be red-tinted red using the following:

Code: Select all

        [effect]
            apply_to=profile
            portrait="portraits/undead/spectre.png~GS()~BLEND(255,0,0,0.5)"
        [/effect]

-it would be nice if satan claus had a [message] when appearing, like "Ho ho ho!"

[ForestDragon]

more ideas:
-it would be nice if there was a lvl4 option for satan claus, instead of just 1,2,3
-checkbox idea: option to give satan the regeneration ability
-it would be nice if the "Jingle Bells" attack damage scaled accordingly to the selected level. this will both allow
-in the restrictions option menu, the difference between the first/second options isn't very clear. It would be a good idea to specify what exactly the second option does.

[Choicerer]

some more ideas for the mod:
-you can give satan 50% defense on impassable terrain by using the following effect inside an [object] (right now his ability to pass though walls can be exploited in some cave maps due to his having 0% defense in the walls):

Code: Select all

        [effect]
            apply_to=defense
            replace=true
            [defense]
                impassable=50
            [/defense]
        [/effect]

Done.

-you can change satan's profile image to be red-tinted red using the following:

Code: Select all

        [effect]
            apply_to=profile
            portrait="portraits/undead/spectre.png~GS()~BLEND(255,0,0,0.5)"
        [/effect]

Done.

-it would be nice if satan claus had a [message] when appearing, like "Ho ho ho!"

I've thought about that, but I didn't want to spam multiplayer scenarios with messages too much. He does scream, though. Like a griphon.

Yes, damage set to more than 9 causes it, too. I'll fix it shortly.

I've identified the bug. It was caused by Wesnoth not being able to handle double negative values. Now the limit's been increased to 20 damage and 10 strikes (crazy, I know) and it works.

[ForestDragon]

I've identified the bug. It was caused by Wesnoth not being able to handle double negative values. Now the limit's been increased to 20 damage and 10 strikes (crazy, I know) and it works.

Well, the more customization possibility, the better

[ForestDragon]

bugreport, in the 1.4.0e version when satan tries to attack, the following error message appears during each attack attempt, and the attack doesn't happen (I set hp to 30 damage to 8, and strikes to 2 (works when damage is set to 10 or, though, but sometimes doesn't work even then)):