Rushed By Yetis

[iceiceice]

New version: 1.20.25:

Changes:
- 2p - Crescent Lake updated
- New "RBY Explorer 2v2" map pool, includes the "classic" pool plus 4p - Crescent Lake, 4p - Ruins of Terra Dwelve, 4p - Underworld.

This is probably the last release for wesnoth 1.10. I have plans for a 1.12 version not too long from now, but I plan to make some significant changes first.

(I think it actually works fine in it's current version for 1.12, you can just drop the add-on folder to 1.12 in the meantime if you want, but I would like to make use of some of the new features in 1.12 to make no mirror era work better.)

Please report any bugs, thanks.

[iceiceice]

New version 1.11.26:

The new release is available now for wesnoth 1.11! It will also be available when 1.12 is formally announced.

Main changes:
- Fixed a bug in the no mirror era which caused it to fail, thanks to Mint for reporting.
- After the rage in me subsided that omitting a single $ in WML can cause a non-obvious bug and no syntax errors reported... I resolved to rewrite the whole thing in lua to improve maintainability.
- Taking advantage of 1.11 / 1.12 features, the no mirror era is no longer an era, it is a multiplayer "modification". This is great because it can now be applied to any era, not just the default era. So we now get for free a "Default + Khalifate no mirror" and "Alternate Era no mirror" etc. etc.

Please report any bugs, thanks.

[SatHyre]

hello,
how to add new maps in the RBY 2 vs 2.
there are new maps added by velensk in add-ons, and i want them to be in the list of rby explorer 2 vs 2.
thanks in advance.

[iceiceice]

Hi,

The map pools are all in the "campaigns" folder in the RBY add-on. This is the one that makes RBY Explorer:

https://github.com/WesnothRBY/picker/bl ... er_2v2.cfg

For example if you want to add a new map, you can add a new line here like

Code: Select all

 ...
{RBY_CASE_NEXTSCEN 7 "FOO"} 
...

And you have to increase the 6 at line 20 to a 7. You should also update the description strings in this file.

You also need to actually add the content of FOO to the RBY add-on if its a map that isn't already there. For this you go to the "scenarios" folder.

• You should copy the .map file to the "scenarios/maps" folder.
• You should put the .cfg file in the "scenarios/configs" folder, however you need to tweak to the .cfg file, so that RBY side shuffling will work.
  
  Basically the .cfg file gets chopped up into two parts.
  For each map, the two files "FOO.cfg" in "scenarios/configs" and "scenarios/macros" work together to define the RBY scenario corresponding to FOO.
  Spoiler:

  • The RBY-related WML goes in the file in "scenarios/configs".
    This file should basically look exactly the same for every map. For instance, start with the one for 4p Crescent Lake.
    
    • If the TOD schedule is different from default, change this line. Look for instance at Loris River or Terra Dwelve for examples.
    • If the turn order is "Team 1 - Team 2 - Team 2 - Team 1", then you don't need to change these lines. If it's staggered, like Clash, then swap appearance of "D" with "C" like so. In general "A" and "D" are a team, and "B" and "C" are a team.
    • If the players get non-default amounts of Gold then use {RBY_SIDE_WITH_GOLD} macro, like in Terra Dwelve.
    • All remaining details of the scenario get put into "RBY_SETTINGS_FOO" macro, which will be defined in the other file "scenario/macros/FOO.cfg".
      
      The string you put as argument at this line needs to match exactly with what you put in the "campaigns/configs" file.
    • You should update the first and last lines changing "RBY_CRESCENT_LAKE_FOUR_INSTANCE" to "RBY_FOO_INSTANCE".
  • Stuff specific to this scenario config file goes in a file in "scenarios/macros". Most of the time this is just id and description. Here's an example. Here's another where the map is not a core wesnoth map and has to be drawn from RBY.
  • Here's an example for what to do if the scenario has complex scripted events: serpent ford aethermaw. All that stuff should go into the file in "scenario/macros" so that it doesn't get confusing what WML is RBY-related and what is not.
  Most 2 v 2 maps don't have any crazy scripting, in which case this step is pretty easy. Just use Clash or Loris River etc. as a template, according to time of day / player ordering etc.
• I guess the original map and cfg files are supposed to go into "resources/maps" and "resources/scenarios". I don't think this is too important, but its not a bad idea, so we always have copies of the originals and so does anyone who downloads the add-on. (And the author can easily check if we have an out of date version.)

If you add new maps that are good and make a pull request on github, I will review it and maybe make a new official RBY release with your work so that everyone can enjoy it . You could add new maps to 2 v 2 Explorer, or make a third 2 v 2 pool.

In general adding new 1 v 1 maps to RBY is contentious and something to be done by consensus with the wesnoth ladder players basically. RBY 2 v 2 maps is not related to that, its just a spin-off that I made. Whatever 2 v 2 maps are known to be good or are "up and coming" can be there. Its best to have "stable" maps because if the map gets updated by the author you have to do some work to update in RBY also.

It might be nice to add Horus' map from the tournament also... (note to self)...

Cheers,
~iceiceice~

[pe_em]

Hello,

RBY seems terribly bugged for 1.12. I think that every ladder player can easily count some of bugs.

So firstly, the most important and - also - making the game unfair bug is the fact that you are able to recall your enemy's leader. It makes ladder games unfair if someone only check the list of veterans.

Secondly, game often crashes at the begining for p2 and p1 is informed that "p2 has disconnected".

Sometimes at the start vision switches to your opponent's side, then to your side so you know his leader and faction.

Sometimes OOS occur at the beginning of the game.

These are all of bugs I know so far. Please fix them, because RBY is the only random map picker available on 1.12 and the players have no choice if they want to choose the map randomly.

Thanks, pe_em.

PS. RBY Generator on heroku.com is outdated.

[iceiceice]

Hi, sorry for slow response.

In general I don't check the forums every day and I don't get an email when my threads are posted in -- if you want to make sure I know about something, send me a PM.

Cackfiend pm'd me about this in November and I promised to look at it, but I've been busy -- sorry again. If someone wants to take over maintenance of RBY they would be welcome. Note that in 1.13 I added a feature so that the "random no mirror" stuff can be handled by the application itself which is simpler than doing it inside RBY, so going forward RBY will transition to being mainly a map pool I guess. Point is it might be simpler to maintain.

Anyways I plan to take a look at this over holiday break -- but I did test the 1.12 version myself when 1.12 was released, so, sorry that bugs got through.

[iceiceice]

Also: pb_em, can you describe exactly what circumstances the bugs occur under? For instance, with RBY Era only, with RBY Era and map pool, with RBY map pool but not era?

Note that using RBY era without the map pool is not supported, it will always lead to a broken replay (it was always that way), and in 1.12 it's not different but you might get worse side effects.

[pe_em]

Also: pb_em, can you describe exactly what circumstances the bugs occur under? For instance, with RBY Era only, with RBY Era and map pool, with RBY map pool but not era?

It is very various. I'm just trying to reproduce the bugs and will send you the results.


I am working on BfW 1.12.4 and Windows 10. Using LAN server and latest version of RBY.

Created the RBY Classic game with RBY No Mirror. Both sides are random. Game loaded for the host. Strangely his teamcolor is blue and he's side 2 (Shuffle sides disabled).
Game didn't load for the second player. Received OOS:

Code: Select all

found dependent command while is_synced=false

Then game crashed:

RBY Classic without RBY No Mirror. Both sides random.
Game loaded for both sides.Side 1 became visible for host for a while, then visibility switched to side 2. Both sides received the messages:

Host is again P2 blue.
I haven't found any more problems in this game. Players aren't even able to summon enemy's leader.


RBY Adv + Con with RBY No Mirror. Both sides random. Shuffle sides enabled.

Game loaded for both sides. Host is red P1. P2 received a Lua error:

Again, the players aren't able to summon enemy's leader.

I think that these tests are enough for finding the circumstances of the bugs. I am just curious why the players aren't able to recall enemy's leader as it had been possible. Hope they will help you.