[mainline] Changing the Dunefolk's(Khalifate's) unit names
Moderator: Forum Moderators
Forum rules
Before posting a new idea, you must read the following:
Before posting a new idea, you must read the following:
- Pentarctagon
- Project Manager
- Posts: 5539
- Joined: March 22nd, 2009, 10:50 pm
- Location: Earth (occasionally)
Re: [mainline] Changing the Dunefolk's(Khalifate's) unit nam
It wasn't part of my initial plans, since changing them came up more as part of the lore discussion, and that's ongoing. It's probably a bit late to start discussing them at this point too, unless the only question is whether to change Falcon -> Elder Falcon to Roc/Ruhk/etc -> Elder Roc/Ruhk/etc.Celtic_Minstrel wrote:Might want to hold off on falcons though, since we might decide to turn them into rocs.SigurdFireDragon wrote:(Side note: Falcons, Saurians, & Wolves still need one as well, Writer's Forum threads welcome)
Speaking of which, that's one thing this whole rename scheme seems to have excluded from the start; they came up in discussion but were never on the list of units to change. Were there any plans to look at the falcons in addition to the human dunefolk?
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code
take one down, patch it around
-2,147,483,648 little bugs in the code
- Pentarctagon
- Project Manager
- Posts: 5539
- Joined: March 22nd, 2009, 10:50 pm
- Location: Earth (occasionally)
Re: [mainline] Changing the Dunefolk's(Khalifate's) unit nam
The second poll has been started for the Shuja -> Khalid. Everyone gets a single vote, and the poll will last for two days.
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code
take one down, patch it around
-2,147,483,648 little bugs in the code
- Celtic_Minstrel
- Developer
- Posts: 2169
- Joined: August 3rd, 2012, 11:26 pm
- Location: Canada
- Contact:
Re: [mainline] Changing the Dunefolk's(Khalifate's) unit nam
I don't think I saw any other suggestions, unless the people talking about wyvern riders were assuming they'd replace the falcons.Pentarctagon wrote:It's probably a bit late to start discussing them at this point too, unless the only question is whether to change Falcon -> Elder Falcon to Roc/Ruhk/etc -> Elder Roc/Ruhk/etc.
...and it seems like all the good (in my opinion) Shuja->Khalid options didn't make it. Oh well?
- Pentarctagon
- Project Manager
- Posts: 5539
- Joined: March 22nd, 2009, 10:50 pm
- Location: Earth (occasionally)
Re: [mainline] Changing the Dunefolk's(Khalifate's) unit nam
Alright.Celtic_Minstrel wrote:I don't think I saw any other suggestions, unless the people talking about wyvern riders were assuming they'd replace the falcons.Pentarctagon wrote:It's probably a bit late to start discussing them at this point too, unless the only question is whether to change Falcon -> Elder Falcon to Roc/Ruhk/etc -> Elder Roc/Ruhk/etc.
edit-
Also, I suppose this is also as good a time to ask as any: What would be needed for backwards compatibility between all the new/old unit names? I haven't done anything with units or unit types in years.
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code
take one down, patch it around
-2,147,483,648 little bugs in the code
Re: [mainline] Changing the Dunefolk's(Khalifate's) unit nam
I would see it as hidden base_unit with old id, with added event that on unit placed logs warning message and advances to new type.
Re: [mainline] Changing the Dunefolk's(Khalifate's) unit nam
Ravana's idea sounds great! It will minimize the effect of the renaming.
In my understanding, unit type definition may look like the following? (not tested, though)
In my understanding, unit type definition may look like the following? (not tested, though)
Code: Select all
[unit_type]
id=Arif
[base_unit]
id=Dune Soldier
[/base_unit]
advances_to=Dune Soldier
hide_help=yes
do_not_list=yes
[event]
name=unit placed
first_time_only=no
[filter]
type=Arif
[/filter]
[wml_message]
logger=warn
message=_"Arif is an obsolete name. Use Dune Soldier instead blablabla."
[/wml_message]
[transform_unit]
x,y=$x1,$y1
[/transform_unit]
[/event]
[/unit_type]
Discord: @tamanegi
It is true that we cannot be free from bugs, but at least let our bugs not always the same...
A Group in a War: my first campaign, An Independence War: and the sequel
It is true that we cannot be free from bugs, but at least let our bugs not always the same...
A Group in a War: my first campaign, An Independence War: and the sequel
- Celtic_Minstrel
- Developer
- Posts: 2169
- Joined: August 3rd, 2012, 11:26 pm
- Location: Canada
- Contact:
Re: [mainline] Changing the Dunefolk's(Khalifate's) unit nam
Much like tamanegi said, but also add
...also, is the
race=khalifate
so that race filters continue to work, and use [deprecated_message]
instead of [wml_message]
to gain the benefit of deprecation levels....also, is the
[transform_unit]
just there to visibly highlight it? I'm not sure that's necessary, to be honest.- Pentarctagon
- Project Manager
- Posts: 5539
- Joined: March 22nd, 2009, 10:50 pm
- Location: Earth (occasionally)
Re: [mainline] Changing the Dunefolk's(Khalifate's) unit nam
So, to clarify, the existing Arif.cfg would be renamed to Soldier.cfg(along with the necessary internal changes to
And then rinse and repeat for all the units. Or should it have
edit-
Apparently [deprecated_message] is bugged in master at the moment.
id
and whatnot), and a new Arif.cfg would be created containing the below WML?Code: Select all
[unit_type]
id=Arif
race=khalifate
[base_unit]
id=Dune Soldier
[/base_unit]
advances_to=Dune Soldier
hide_help=yes
do_not_list=yes
[event]
name=unit placed
first_time_only=no
[filter]
type=Arif
[/filter]
[deprecated_message]
logger=warn
message=_"Arif is an obsolete name. Use Dune Soldier instead."
[/deprecated_message]
[/event]
[/unit_type]
advances_to=Dune Swordsman,Dune Spearguard
? Unless I'm mistaken, otherwise that would have a level one Arif advance to a level one Dune Soldier.edit-
Apparently [deprecated_message] is bugged in master at the moment.
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code
take one down, patch it around
-2,147,483,648 little bugs in the code
Re: [mainline] Changing the Dunefolk's(Khalifate's) unit nam
IMO, the
In my example, the placed "Arif" will immediately advance to "Dune Soldier" by
So the unit name Arif won't appear in-game.
Highlighting of the target unit may not happen during this process (not sure, though) and FULL_HEAL does not happen.
Celtic_Minstrel might mean we should just place a new unit instead of advancing the old unit.
But I don't know how to copy traits and other modifications from the old unit (Arif) to new one (Dune Soldier)...
Adding race=khalifate might be OK. But it means the obsolete race khalifate will still exist in the core?
If so, I suppose that khalifate will appear as a help item... It may not be welcome, IMHO.
[transform_unit]
is still necessary.In my example, the placed "Arif" will immediately advance to "Dune Soldier" by
[transform_unit]
.So the unit name Arif won't appear in-game.
[transform_unit]
without transform_to
makes the target unit advance according to the unit's advances_to
.Highlighting of the target unit may not happen during this process (not sure, though) and FULL_HEAL does not happen.
Celtic_Minstrel might mean we should just place a new unit instead of advancing the old unit.
But I don't know how to copy traits and other modifications from the old unit (Arif) to new one (Dune Soldier)...
Adding race=khalifate might be OK. But it means the obsolete race khalifate will still exist in the core?
If so, I suppose that khalifate will appear as a help item... It may not be welcome, IMHO.
Discord: @tamanegi
It is true that we cannot be free from bugs, but at least let our bugs not always the same...
A Group in a War: my first campaign, An Independence War: and the sequel
It is true that we cannot be free from bugs, but at least let our bugs not always the same...
A Group in a War: my first campaign, An Independence War: and the sequel
-
- Developer
- Posts: 546
- Joined: January 12th, 2011, 2:18 am
- Location: Pennsylvania, USA
Re: [mainline] Changing the Dunefolk's(Khalifate's) unit nam
Maybe it would be simpler to do just this, and allow the old id's to function until the end of the deprecation period?
If all the units of a race are hidden from help, would it still show up in help?
A log warning could be added to this as well
[quote="SigurdFireDragon"]While the old id's are being deprecated, adding advances_to would ensure filters don't break when the unit advances & help with compatibility.
If all the units of a race are hidden from help, would it still show up in help?
A log warning could be added to this as well
[quote="SigurdFireDragon"]While the old id's are being deprecated, adding advances_to would ensure filters don't break when the unit advances & help with compatibility.
Code: Select all
[unit_type]
id=Rami
[base_unit]
id=Dune Rider
[/base_unit]
advances_to=Qanas,Saree
race=khalifate
hide_help=yes
do_not_list=yes
[/unit_type]
Co-Author of Winds of Fate
My Add-ons: Random Campaign, Custom Campaign, Ultimate Random Maps, Era of Legends, Gui Debug Tools
Erfworld: The comic that lead me to find Wesnoth.
My Add-ons: Random Campaign, Custom Campaign, Ultimate Random Maps, Era of Legends, Gui Debug Tools
Erfworld: The comic that lead me to find Wesnoth.
- Celtic_Minstrel
- Developer
- Posts: 2169
- Joined: August 3rd, 2012, 11:26 pm
- Location: Canada
- Contact:
Re: [mainline] Changing the Dunefolk's(Khalifate's) unit nam
Yeah Sigurd, that's the general idea. Anything that was made using the old IDs should continue to function through 1.1, which means all units originally placed with the old IDs need to stay with the old IDs.
-
- Posts: 52
- Joined: October 17th, 2015, 10:15 pm
Re: [mainline] Changing the Dunefolk's(Khalifate's) unit names
why was khalid removed from the game?
- James_The_Invisible
- Posts: 534
- Joined: October 28th, 2012, 1:58 pm
- Location: Somewhere in the Northlands, fighting dark forces
- Contact:
Re: [mainline] Changing the Dunefolk's(Khalifate's) unit names
It was not removed, just renamed to Dune Warmaster.
My content: For Power series
Ports: Danse Macabre Story of the Wose
Guides: How to translate your UMC
Ports: Danse Macabre Story of the Wose
Guides: How to translate your UMC
-
- Posts: 52
- Joined: October 17th, 2015, 10:15 pm
Re: [mainline] Changing the Dunefolk's(Khalifate's) unit names
in my game the Arif can only be upgraded to lvl 3. (steam version)James_The_Invisible wrote: ↑January 14th, 2020, 5:59 pmIt was not removed, just renamed to Dune Warmaster.
Edit: https://units.wesnoth.org/1.14/mainline ... l#Dunefolk
even here it says he cant be upgraded from lvl 3 to lvl 4 (separate tree)
- James_The_Invisible
- Posts: 534
- Joined: October 28th, 2012, 1:58 pm
- Location: Somewhere in the Northlands, fighting dark forces
- Contact:
Re: [mainline] Changing the Dunefolk's(Khalifate's) unit names
Yes, it is not possible unless the campaign you are playing allows it.DwarvenWarrior wrote: ↑January 14th, 2020, 7:07 pm in my game the Arif can only be upgraded to lvl 3. (steam version)
Edit: https://units.wesnoth.org/1.14/mainline ... l#Dunefolk
even here it says he cant be upgraded from lvl 3 to lvl 4 (separate tree)
My content: For Power series
Ports: Danse Macabre Story of the Wose
Guides: How to translate your UMC
Ports: Danse Macabre Story of the Wose
Guides: How to translate your UMC