[Interface] When a Horseman becomes a Knight

[ktchong]

The game should automatically add the title "Sir" in front of the unit's name.

[Pentarctagon]

Moved to the Ideas forum.

[Pewskeepski]

That would be cool, but I'm not sure how easy I'd be to implement.

[Boldek]

That would be awesome!

[Ceres]

Couldn't you do that with plain WML? Something like this?

Code: Select all

[event]
   name=post advance
   first_time_only=no
   [filter]
      type=Knight
   [/filter]
   [modify_unit]
      [filter]
         id=$unit.id
      [/filter]
      name="Sir " + $unit.name
   [/modify_unit]
[/event]

[Elvish_Hunter]

The game should automatically add the title "Sir" in front of the unit's name.

May I ask why should it?

Couldn't you do that with plain WML? Something like this?

Code: Select all

[event]
   name=post advance
   first_time_only=no
   [filter]
      type=Knight
   [/filter]
   [modify_unit]
      [filter]
         id=$unit.id
      [/filter]
      name="Sir " + $unit.name
   [/modify_unit]
[/event]

Yes, it CABD in WML. Although there may be two issues:
- the translation mark before "Sir " is missing; and anyway, I suspect that several languages lack a translation for that title
- what if, due to a campaign's plot, that Horseman already has the "Sir" title?
In conclusion, ktchong, feel free to do it in your campaign or add-on, but I'm pretty sure that this is not going to happen in mainline.

[Iris]

- the translation mark before "Sir " is missing; and anyway, I suspect that several languages lack a translation for that title

Concatenating strings where at least one of them is meant to be translatable should be done sparingly, in general, in case they need to be translated to languages that require reordering or merging words. (See this too.)

[ktchong]

In conclusion, ktchong, feel free to do it in your campaign or add-on, but I'm pretty sure that this is not going to happen in mainline.

I already manually changed the names of my Sir Knights. Just a suggestion; thought it would be nifty and impressive if players (who pay attention to details) see their upgraded Knights would also gain the new title.

[Xudo]

When do you really look at unit names, anyway?

Copyright: http://forums.wesnoth.org/viewtopic.php ... 91#p512613

[uncleshelby]

With WML, you could make it check if the name starts with "Sir", and then change the name from that, right?

[Gambit]

Denied.