good point, I'll post a couple of guidelines for patch submission, and make that topic sticky while I'm at it....
All patches should be submitted at patches.wesnoth.org
You can post them here too for discussion, but we need to track what is their status and p.w.o helps a lot
patch should be generated using "svn diff
SVN provides a cool command to generate diff, just run "svn diff >mypatch.patch" to create the patch, and its all nice and ready
it even records precisely the commit against which it was generated, it makes things really easy for us...
Dont forget to add an entry to the Changelog
Add yourself in about.cfg
including your name and/or nick it makes it easier for us.
new contributors should go in the contributor section of the about file
when changing WML, please add a pointer in the wiki to where it should be updated when commited
be patient, sometime we are not very responsive
don't be suprised if we discuss the patch a lot
thus, you should leave us a way to contact you, either a forum nick, an email adress, or submit with a registered gna account.
we try as much as possible to apply patch "as is" which means that we will usually ask you to change a patch rather than changing it ourselves...
The patch should generate no warnings
wesnoth has a large number of warnings enabled, all of them are usefull, if your code spits warning, please have a look, and ask yourself why you are doing what causes the warning.
When adding a file, don't forget src/Makefile.am, src/SConscript, src/CMakeLists.txt, projectfiles/VC9/wesnoth.vcproj
it makes things simpler for us, and is often forgotten
sometime patches are rejected, don't be suprised if it happens
that's all for the moment, we'll probably add some more later[/b]
Last edited by Crab
on September 12th, 2009, 10:42 pm, edited 1 time in total.
Reason: added note about projectfiles/VC9/wesnoth.vcproj
Fight key loggers: write some perl using vim