Some patch questions

Post by **Baufo** » November 24th, 2006, 8:19 pm

Yesterday I downloaded the source code of 1.3 from svn the first time. I toyed around with it a bit and so far it's quite exciting, even if nearly every piece of code confuses me.

Well, I made a little patch - an extra tag to float text above units which I longed for when writing WML. It's about 5 lines of code

Generally, should I ask on IRC if it could be useful before submitting a patch or just do it and see what happens?
And is this strange *.patch - file that svn diff created enough, does it contain all necessary information?

Post by **SkeletonCrew** » November 24th, 2006, 8:30 pm

Baufo, please read this post it answers all your questions and more

http://www.wesnoth.org/forum/viewtopic. ... 866#136866

Post by **Noyga** » November 24th, 2006, 8:34 pm

If you want to submit ÃƒÂ patch, do it at http://patches.wesnoth.org
SVN diff patches are what is the most convenient to us, developers, to test you patch.
You might want to modify the changelog, this would help our lazy devs

If it's your first patch you might want to add yourself to data/about.cfg too

Post by **Baufo** » November 24th, 2006, 9:05 pm

Thank you, this already helped a lot.
So I should make a patch - file of the changelog and about.cfg too?

Post by **SkeletonCrew** » November 24th, 2006, 10:21 pm

If you modify the changelog and about.cfg and do "svn diff >patch" in the root the changes in all your modifications are put in 1 diff. This diff you can post at http://patches.wesnoth.org .

Website · Post by **Sapient** » November 26th, 2006, 1:11 am

I already added code to float text above units. It's in unstore_unit.